Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #94 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 4 4
Lines 220 220
=======================================
Hits 206 206
Misses 14 14 🚀 New features to boost your workflow:
|
Contributor
|
The original rationale for the tests were to test that installation happened correctly. If the sub-package tests run, then code that uses the sub-packages should run. So there is value in these tests. IF we can think of another way of testing this, we could go there. For example, successfully importing everything from the sub-packages. It just seemed easier to run the tests from the sub-packages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After conversing with Chatgpt, it seems like the reason this CI is failing is because of a leaked error code that doesn't get cleaned up.
The whole point of this CI test is to run tests on the diffpy.cmi dependencies
srfit,srreal,pyobjcryst, andutils. All these tests pass when CI runs, but the CI still raises an error likely due to some error code leaking through.I think we should probably have a conversation on if we even want this test. It seems redundant to me to test code from another repo where tests are (presumably) being ran, leading me to believe we don't need any of this CI testing.