deprecate: addProfileGenerator deprecation

[cadenmyers13]

deprecate FitContribution.addProfileGenerator. Dont merge until upstream v4.0.0 branch has been made.

[cadenmyers13]

@sbillinge ready for review. Before merge though, do we want to create a new branch v4.0.0? then we can do all deprecation into there?

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.44%. Comparing base (8db7cc6) to head (92e8158).
⚠️ Report is 15 commits behind head on v3.3.0.

Additional details and impacted files

@@            Coverage Diff             @@
##           v3.3.0     #146      +/-   ##
==========================================
+ Coverage   69.36%   69.44%   +0.07%     
==========================================
  Files          25       25              
  Lines        3457     3466       +9     
==========================================
+ Hits         2398     2407       +9     
  Misses       1059     1059              

Files with missing lines	Coverage Δ
tests/test_contribution.py	99.53% <100.00%> (+0.02%)	⬆️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sbillinge]

@cadenmyers13 I am merging into v3.3.0 as the base branch. Please could you use this as base? 4.0.0 will be the version where we remove the old functions, we want to deprectate for a few minor release bumps and a year or so.

[cadenmyers13]

@sbillinge yep! Sorry I meant the minor bump not major bump you're right