fix: let tests compatible to newer versions of pycifrw#146
Merged
sbillinge merged 2 commits intodiffpy:mainfrom Jul 23, 2025
Merged
fix: let tests compatible to newer versions of pycifrw#146sbillinge merged 2 commits intodiffpy:mainfrom
pycifrw#146sbillinge merged 2 commits intodiffpy:mainfrom
Conversation
Contributor
Author
|
@bobleesj, it's ready for review. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 13 13
Lines 1878 1878
=======================================
Hits 1858 1858
Misses 20 20 🚀 New features to boost your workflow:
|
Contributor
|
ah, its all resolved! Great work @ycexiao !!!! Please ignore all my other comments, this was done very well! |
This was referenced Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR address?
Fix the failed tests as mentioned in #144
The newest version of
pycifrwinconda-forgeis4.4.6, and inPyPIis5.0.1. SomeStarErroris changed toYappsSyntaxErrorin the newer version ofpycifrwand can not be caught by the parser indiffpy.structure. This is why tests failed indiffpy.structure=3.3.1rc0.What should the reviewer(s) do?
Please check if catching the
YappsSyntaxErroras StructureFormatError is what we want.