Fix: respect required: false for env_file in publish command#13652
Open
maks2134 wants to merge 1 commit intodocker:mainfrom
Open
Fix: respect required: false for env_file in publish command#13652maks2134 wants to merge 1 commit intodocker:mainfrom
maks2134 wants to merge 1 commit intodocker:mainfrom
Conversation
Fixes docker#13648 The docker compose publish command was ignoring required: false setting on env_file entries, causing failures when optional env files were missing. Changes made: - Modified checkForSensitiveData() to skip env files with required: false - Updated processFile() to only process required env files into layers - Fixed checkEnvironmentVariables() to only consider required env files - Added comprehensive tests to verify the fix Signed-off-by: Maks Kozlov <maks@example.com> Signed-off-by: maks2134 <maks210306@yandex.by>
ndeloof
approved these changes
Mar 21, 2026
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Fixed docker compose publish command to respect
required: falsesetting on env_file entries. Previously, the command would fail when optional env files were missing, even when explicitly marked as not required.Changes made:
required: falseRelated issue
fixes #13648
(not mandatory) A picture of a cute animal, if possible in relation to what you did