Merged
Conversation
thaJeztah
commented
May 4, 2022
thaJeztah
force-pushed
the
carry_270_centos9
branch
from
a48073c to
3ab3561
Compare
thaJeztah
commented
May 4, 2022
thaJeztah
force-pushed
the
carry_270_centos9
branch
7 times, most recently
from
64ec306 to
3fa047d
Compare
- do not "provide" runc on CentOS/RHEL >= 8 - do not build btrfs on CentOS/RHEL >= 8 - set the correct build-dependency for BTRFS on SUSE flavors and "others" Signed-off-by: Romain Geissler <[email protected]> Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
carry_270_centos9
branch
from
3fa047d to
7913b5b
Compare
Member
Author
Contributor
|
Hi, For what it's worth, these changes look ok for me. Cheers, |
tianon
approved these changes
May 4, 2022
Contributor
tianon
left a comment
tianon
left a comment
There was a problem hiding this comment.
A bit over my head on RPM spec knowledge, but seems sane? 🙈
Member
Author
Thank you, Romain!
They're a big pain, so don't blame you (took me several attempts to get it right with all the different distro combinations 😓) |
Member
Author
|
Let me bring this one in 👍 |
This was referenced May 4, 2022
alunsin
pushed a commit
to alunsin/docker-ce-build
that referenced
this pull request
May 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes;