-
Notifications
You must be signed in to change notification settings - Fork 401
docs: update API server, CLI, DMR provider, and Go SDK for PRs #3199 #3201 #3206 #3182 #3215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+81
−0
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
251b50e
docs: update api-server session endpoints for #3199
aheritier 876a61d
docs: document pprof-addr diagnostics flag for serve api for #3201
aheritier dd06c8e
docs: document DMR local-model auto-discovery for #3206
aheritier 4919c3d
docs: document styles.RegisterBuiltinThemes for Go SDK embedders for …
aheritier dc53ff1
docs: address review feedback on PR #3215
aheritier File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[LOW] Theme YAML example omits
namefield and undocumented fallback behaviorThe
themes/brand.yamlsnippet (line 203–206) shows onlycolors.accentandcolors.background— thename:key is absent. While the code silently falls back to the filename stem (i.e."brand") whenname:is missing, this behaviour is not mentioned anywhere in the new section.Suggested addition after the YAML block:
Without this note, embedders who rely on an exact human-readable label in the picker may be surprised.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in dc53ff1. Added a sentence after the YAML block: "If
name:is omitted, docker-agent uses the filename stem as the display name in the theme picker (e.g.brandfromthemes/brand.yaml)."