Support loading cDAC from SOS installations#5874
Draft
hoyosjs wants to merge 3 commits into
Draft
Conversation
…in CLRMD for cdac + dac scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bundle the cDAC into diagnostics tool packages and implement interim loading policy for DAC/cDAC:
UseCDac(null= default policy described above, true=force, false=never) with--usecdac true|false|policy**DataTargetimplementsICLRContractLocatorand stores resolved contract descriptor address for cDAC initializationsos-packaging.propscleanup to allow any arch packaging;PackageWithCDac=trueby default on main branch so all platforms (win-x64/x86/arm64, linux-*, osx-*) bundle cDAC alongside sos.