iOS device startup: upload .logarchive and pull crash reports on cleanup failure#5232
Open
matouskozak wants to merge 2 commits into
Open
iOS device startup: upload .logarchive and pull crash reports on cleanup failure#5232matouskozak wants to merge 2 commits into
matouskozak wants to merge 2 commits into
Conversation
…nup failure When post-iteration app cleanup fails (devicectl 'No such process'), the app already exited before we could terminate it. To diagnose why — crash, iOS- initiated termination, or natural exit: 1. Zip and upload the iOS device's .logarchive to the Helix results container 2. Pull device-side crash reports (.ips) via xcrun devicectl Investigative-only: triggers only on the cleanup failure that already terminates the iteration. Cherry-picked from matouskozak/ios-sdk-jobs-macos-26 (71bfd4a1, 3101d30c). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds diagnostic collection for iOS device startup cleanup failures, helping investigate cases where the app process is already gone when the runner tries to kill it.
Changes:
- Wraps the iOS app kill step in
CalledProcessErrorhandling. - Uploads the collected
.logarchiveand attempts to copy device crash logs before re-raising. - Adds
make_archiveimport for zipping the log archive.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Pull any iOS crash reports (.ips) for our bundle from the device into the upload root. | ||
| # The systemCrashLogs domain on devicectl exposes /var/mobile/Library/Logs/CrashReporter/. | ||
| crash_dest = os.path.join(upload_root, f'iteration{i}_crashlogs') | ||
| os.makedirs(crash_dest, exist_ok=True) |
Comment on lines
+864
to
+879
| # Pull any iOS crash reports (.ips) for our bundle from the device into the upload root. | ||
| # The systemCrashLogs domain on devicectl exposes /var/mobile/Library/Logs/CrashReporter/. | ||
| crash_dest = os.path.join(upload_root, f'iteration{i}_crashlogs') | ||
| os.makedirs(crash_dest, exist_ok=True) | ||
| crashCopyCmd = [ | ||
| 'xcrun', 'devicectl', 'device', 'copy', 'from', | ||
| '--device', deviceUDID, | ||
| '--domain-type', 'systemCrashLogs', | ||
| '--source', '/', | ||
| '--destination', crash_dest, | ||
| ] | ||
| try: | ||
| getLogger().info(f"Copying device crash logs to {crash_dest} for diagnosis.") | ||
| RunCommand(crashCopyCmd, verbose=True).run() | ||
| except Exception as crash_ex: | ||
| getLogger().warning(f"Failed to copy device crash logs for diagnosis: {crash_ex}") |
Open
3 tasks
- Wrap os.makedirs into the same try/except as the crash copy so a diagnostic-path failure cannot mask the original CalledProcessError from the failed app kill. - Prune the systemCrashLogs copy after devicectl to entries relevant to this iteration: keep files matching the bundle name or with mtime >= the iteration's log-collect start. Drops dozens of unrelated .ips files (WiFiLQMMetrics, wifip2pd, old crashes, etc.) per upload. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When the post-iteration iOS app cleanup fails (devicectl returns 'No such process'), the app already exited before we could terminate it. This PR adds diagnostic data collection to help investigate why — crash, iOS-initiated termination, or natural exit.
Changes
src/scenarios/shared/runner.py:make_archiveto theshutilimportkillCmdCommand.run()in atry/except CalledProcessErrorblock that:.logarchivetoHELIX_WORKITEM_UPLOAD_ROOT.ips) viaxcrun devicectl device copy from --domain-type systemCrashLogsWhy
Origin
Cherry-picked from
matouskozak/ios-sdk-jobs-macos-26(commits 71bfd4a1, 3101d30c) which were left unmerged after PR #5231 was merged.Verification
python3 -m py_compile src/scenarios/shared/runner.pypasses