Add Decimal32, Decimal64, Decimal128#100729
Open
RaymondHuy wants to merge 106 commits into
Open
Conversation
|
Note regarding the |
huoyaoyuan
reviewed
Apr 7, 2024
Member
|
This is on my radar to take a look at; just noting it might be a bit delayed due to other priorities for the .NET 9 release. CC. @jeffhandley |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.
Comments suppressed due to low confidence (1)
src/libraries/System.Runtime/ref/System.Runtime.cs:1
- These new numeric types expose
ToString(string?, IFormatProvider?)overloads but do not implementIFormattable. As a result, composite formatting / interpolated string format specifiers (e.g.,string.Format(\"{0:N}\", value)or$\"{value:N}\") may ignore the format string and fall back to parameterlessToString(). Consider addingSystem.IFormattabletoDecimal32/Decimal64/Decimal128(and updating the CoreLib implementations accordingly); optionally also implementISpanFormattableto match other numerics.
Contributor
Author
|
Hi @tannergooding I have resolved all Copilot comments. You can re-review it when you have time ;) |
This was referenced May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #81376