You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice! @am11 see #125294 where I fix some of the HAVE_XXX things. OpenBSD has a non legacy statfs impl but CMake is being weird and not detecting it and I haven’t figured it out yet.
This gets me through libs.native too except for pal_memory.c as I haven't figured out how to fix it in #125010 yet.
And if I pull that in to just "make it build" I get this link error: ld.lld: error: relocation R_X86_64_PC32 cannot be used against symbol '_post_threaded'; recompile with -fPIC
ld.lld: error: relocation R_X86_64_PC32 cannot be used against symbol '_post_threaded'; recompile with -fPIC
Could you show the surrounding context of this error? Also, have you tried recreating crossrootfs with changes in #125557 to see if it helps?
I forgot about crossrootfs changes. Rebuilding with those changes seems to have fixed this. Sorry about that and thanks for the reminder! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this patch and #125294,
src/native/libs/build-native.sh -cross -os openbsd -a x64succeeds with rootfs.Contributes to #124911.
cc @sethjackson