Add cdac.slnx solution file for cDAC development#125614
Merged
max-charlamb merged 1 commit intodotnet:mainfrom Mar 16, 2026
Merged
Add cdac.slnx solution file for cDAC development#125614max-charlamb merged 1 commit intodotnet:mainfrom
max-charlamb merged 1 commit intodotnet:mainfrom
Conversation
Add a checked-in cdac.slnx to src/native/managed/cdac/ that includes all cDAC library projects and both test projects (unit tests and dump tests). This replaces the README instructions that asked developers to manually create a solution file at the repo root. The solution includes: - /cdac/ folder: Abstractions, Contracts, Reader, Legacy, mscordaccore_universal - /tests/ folder: Unit tests and DumpTests (excludes debuggee programs) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to this area: @steveisok, @tommcdon, @dotnet/dotnet-diag |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a checked-in .slnx for the cDAC area so contributors can open/build the full set of cDAC projects (libraries + tests) without manually creating a solution file.
Changes:
- Add
src/native/managed/cdac/cdac.slnxcontaining all cDAC library projects plus unit tests and dump tests. - Update cDAC README to point developers to opening the checked-in solution file rather than generating one manually.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/native/managed/cdac/cdac.slnx | Introduces a focused cDAC solution including all relevant library and test projects. |
| src/native/managed/cdac/README.md | Updates unit testing documentation to reference opening the checked-in cdac.slnx. |
rcj1
approved these changes
Mar 16, 2026
Member
Author
|
/ba-g docs/solution only change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a checked-in
cdac.slnxtosrc/native/managed/cdac/that includes all cDAC library projects and both test projects (unit tests and dump tests). This replaces the README instructions that asked developers to manually create a solution file at the repo root.Changes
src/native/managed/cdac/cdac.slnx: Solution with all 5 library projects in a/cdac/folder and 2 test projects in a/tests/folder. Debuggee programs are excluded since they are build-time dependencies, not direct dev targets.src/native/managed/cdac/README.md: Replaced the Setting up a solution section (which had an incomplete template missing Legacy and DumpTests) with an Opening the solution section referencing the checked-in file.Validation
dotnet build cdac.slnxsucceeds with 0 warnings