[release/10.0] Fix Mono AOT crash on struct fields with unsupported marshal conversion#125618
Open
github-actions[bot] wants to merge 1 commit intorelease/10.0from
Open
[release/10.0] Fix Mono AOT crash on struct fields with unsupported marshal conversion#125618github-actions[bot] wants to merge 1 commit intorelease/10.0from
github-actions[bot] wants to merge 1 commit intorelease/10.0from
Conversation
When a struct contains a reference type field (string, class, array) with MONO_MARSHAL_CONV_NONE (e.g. from UnmanagedType.CustomMarshaler), the AOT compiler hits g_assert_not_reached() in emit_struct_conv_full, causing a SIGABRT. This happens with StructWithCustomMarshalerField in the ICustomMarshaler test: a struct with [MarshalAs(UnmanagedType.CustomMarshaler)] on a string field. The test expects a TypeLoadException at runtime, but the AOT compiler crashes before it gets there. Handle MONO_TYPE_STRING, MONO_TYPE_CLASS, MONO_TYPE_OBJECT, MONO_TYPE_SZARRAY, and MONO_TYPE_ARRAY in the MONO_MARSHAL_CONV_NONE path by emitting a MarshalDirectiveException instead of asserting. This lets the AOT compiler complete and the runtime throw the expected exception. Fixes #125168 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
github-actions
bot
requested review from
steveisok,
thaystg and
vitek-karas
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #125575 to release/10.0
/cc @lewing
Customer Impact
This is both an infrastructure fix and a correctness fix. The test is actively failing in ci, the change fixes an aot compiler crash and turns it (correctly) into a runtime error.
Regression
[If yes, specify when the regression was introduced. Provide the PR or commit if known.]
Testing
Fails continuously in runtime-llvm pipeline but is marked as Known Build Error
Risk
Low, the previous code was
IMPORTANT: If this backport is for a servicing release, please verify that:
release/X.0-staging, notrelease/X.0.release/X.0(no-stagingsuffix).Package authoring no longer needed in .NET 9
IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.