[ci-scan] Skip ActivityTracking tests on Android Mono (refs #129088)#129094
Merged
BrzVlad merged 3 commits intoJun 10, 2026
Conversation
The BasicEventSourceTests.ActivityTracking tests consistently fail on Android because the Activity ID remains zero after EventSource Start/Stop operations. This disables the four affected tests on Android with a reference to the tracking KBE issue. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
Tagging subscribers to 'arch-android': @vitek-karas, @simonrozsival, @steveisok, @akoeplinger |
BrzVlad
reviewed
Jun 9, 2026
Co-authored-by: BrzVlad <4720621+BrzVlad@users.noreply.github.com>
Copilot
AI
changed the title
[ci-scan] Skip ActivityTracking tests on Android (refs #129088)
[ci-scan] Skip ActivityTracking tests on Android Mono (refs #129088)
Jun 9, 2026
BrzVlad
approved these changes
Jun 9, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates System.Diagnostics.Tracing ActivityTracking unit tests to be skipped only on Android when running on the Mono runtime, by adding a new [ActiveIssue] condition that requires both PlatformDetection.IsAndroid and PlatformDetection.IsMonoRuntime.
Changes:
- Add a new
[ActiveIssue]attribute to the four failingBasicEventSourceTests.ActivityTrackingtests. - Gate the skip specifically to the
IsAndroid && IsMonoRuntimecombination (multiple conditions within one[ActiveIssue]are combined with&&in the test wrapper generator).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reasoning
The
BasicEventSourceTests.ActivityTrackingtests consistently fail on Android when running on the Mono runtime because the Activity ID remains as all-zeros Guid after EventSource Start/Stop operations. On Android with Mono, the threading/activity context does not propagate as expected, causingAssert.NotEqual(Guid.Empty, ...)to fail.The fix narrows the
[ActiveIssue]condition to Android + Mono only by usingPlatformDetection.IsAndroidtogether withPlatformDetection.IsMonoRuntime. All four affected tests share the same root cause, and the updated skip scope now matches the failing legs more precisely than the original Android-wide condition.Linked KBE: #129088
Match verification (from Step 4.8):
BasicEventSourceTests.ActivityTracking.StartStopCreatesActivityand 3 sibling testsAssert.NotEqual() Failure: Values are equalwith ExpectedNot 00000000-0000-0000-0000-000000000000Impact on platforms
Errors log
First build it occurred
Linked issue
#129088
Filed by
ci-failure-scan, which scans dnceng-public outer-loop pipelines onmainand converts stable failures into KBEs and test-disable PRs. Comment here or on the workflow file to suggest changes;ci-failure-scan-feedbackreads in-scope feedback daily and opens (or updates) a PR with prompt edits.> [!NOTE]
>
> Generated by CI Outer-Loop Failure Scanner · ● 38.1M · ◷