Skip to content

[release/8.0-staging] Disable failing iOS device tests#130473

Open
vitek-karas wants to merge 1 commit into
dotnet:release/8.0-stagingfrom
vitek-karas:disable-ios-device-tests-8-staging
Open

[release/8.0-staging] Disable failing iOS device tests#130473
vitek-karas wants to merge 1 commit into
dotnet:release/8.0-stagingfrom
vitek-karas:disable-ios-device-tests-8-staging

Conversation

@vitek-karas

Copy link
Copy Markdown
Member

Summary

  • Disable iOS.Device.Aot.Test and iOS.Device.ExportManagedSymbols.Test on this servicing branch.
  • The tests only run on physical iOS devices and no longer provide useful CI signal.
  • The servicing test infrastructure will not be updated for newer macOS versions.

Related to #119665.

Testing

Not run locally because these tests require physical iOS device infrastructure. CI will validate the change.

Note

This PR description was generated by GitHub Copilot.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: e1f236c5-5883-4685-bf00-3bbe551f7a2d
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @akoeplinger, @matouskozak, @simonrozsival
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR disables two iOS physical device functional tests on the release/8.0-staging servicing branch by marking their projects as IgnoreForCI, aligning with the stated intent that servicing CI infrastructure won’t be updated for newer macOS/Xcode versions and the tests no longer provide actionable CI signal.

Changes:

  • Mark iOS.Device.Aot.Test as IgnoreForCI so it will be excluded from CI runs.
  • Mark iOS.Device.ExportManagedSymbols.Test as IgnoreForCI so it will be excluded from CI runs.
  • Add an inline rationale comment in each project file explaining why CI is being disabled.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/tests/FunctionalTests/iOS/Device/AOT/iOS.Device.Aot.Test.csproj Sets <IgnoreForCI>true</IgnoreForCI> to disable this device-only test project in CI on the servicing branch.
src/tests/FunctionalTests/iOS/Device/ExportManagedSymbols/iOS.Device.ExportManagedSymbols.Test.csproj Sets <IgnoreForCI>true</IgnoreForCI> to disable this device-only test project in CI on the servicing branch.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mrek-msft

Copy link
Copy Markdown
Member

Hi,

the code complete date for 8.0.30 (the August 2026 release) is Monday 2026-07-13. Make sure to merge this PR on that date at the latest, or it won't make it into that release.

As a reminder, to merge it, you need Tactics approval, the PR needs to be approved by another area co-owner and there can't be any CI failures that could be related to the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants