feat(Table): update FitColumnWidthIncludeHeader default value to true#7962
Merged
feat(Table): update FitColumnWidthIncludeHeader default value to true#7962
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the Table component so that auto-fit column width calculations include the header row by default, adjusting only the parameter’s default value and its documentation comments. Updated class diagram for Table FitColumnWidthIncludeHeader defaultclassDiagram
class Table_TItem_ {
+Func_string_int_Task_int_ OnAutoFitColumnWidthCallback
+bool FitColumnWidthIncludeHeader = true
}
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Table<TItem> component’s column auto-fit behavior by changing the default of FitColumnWidthIncludeHeader to include header content when calculating column widths, aligning with the requested feature change in #7961.
Changes:
- Changed
FitColumnWidthIncludeHeaderdefault value fromfalse(implicit) totrue(explicit initializer). - Updated the XML documentation to reflect the new default.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
1835
to
+1840
| /// <summary> | ||
| /// <para lang="zh">获得/设置 列宽自适应时是否包含表头 默认 false</para> | ||
| /// <para lang="en">Gets or sets Whether to include header when auto fit column width. Default false</para> | ||
| /// <para lang="zh">获得/设置 列宽自适应时是否包含表头 默认 true</para> | ||
| /// <para lang="en">Gets or sets Whether to include header when auto fit column width. Default true</para> | ||
| /// </summary> | ||
| [Parameter] | ||
| public bool FitColumnWidthIncludeHeader { get; set; } | ||
| public bool FitColumnWidthIncludeHeader { get; set; } = true; |
Comment on lines
1839
to
+1840
| [Parameter] | ||
| public bool FitColumnWidthIncludeHeader { get; set; } | ||
| public bool FitColumnWidthIncludeHeader { get; set; } = true; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #7961
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Enhancements: