Skip to content

add missing parentheses to %test:name() annotation#1192

Merged
joewiz merged 1 commit intoeXist-db:masterfrom
daliboris:fix/xqsuite
Jan 7, 2026
Merged

add missing parentheses to %test:name() annotation#1192
joewiz merged 1 commit intoeXist-db:masterfrom
daliboris:fix/xqsuite

Conversation

@daliboris
Copy link
Copy Markdown
Contributor

@daliboris daliboris commented Jan 6, 2026

%test:name() annotation has value, so the parameter must be enclosed in parentheses.

Copy link
Copy Markdown
Member

@joewiz joewiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Confirmed with a search of instances of this annotation in the eXist source: https://github.com/search?q=repo%3AeXist-db%2Fexist%20%22%25test%3Aname%22&type=code. All instances include a parameter as shown here.

@joewiz joewiz merged commit bb43315 into eXist-db:master Jan 7, 2026
2 checks passed
@adamretter
Copy link
Copy Markdown
Contributor

adamretter commented Jan 7, 2026

annotation is a function

Annotations cannot be functions, I think you mean that the annotation has value(s)

p.s. I think the title of your PR may be wrong, instead of %app:name() did you mean %test:name()?

@joewiz
Copy link
Copy Markdown
Member

joewiz commented Jan 7, 2026

Indeed. For the relevant portion of the spec, see https://www.w3.org/TR/xquery-31/#id-annotations.

No changes to the commit's contents are needed.

@adamretter
Copy link
Copy Markdown
Contributor

No changes to the commit's contents are needed.

Yup, just in git the (1) commit message is misleading, (2) the merge commit message has the same problem

@daliboris daliboris changed the title add missing parentheses to %app:name() annotation add missing parentheses to %test:name() annotation Jan 7, 2026
@daliboris
Copy link
Copy Markdown
Contributor Author

Thank you @adamretter, I changed the title and PR message from GitHub web page.

Is there an easy way to to change the merge commit message too?

@adamretter
Copy link
Copy Markdown
Contributor

Is there an easy way to to change the merge commit message too?

Possible yes, easy no. Probably best to discuss with the owners of this project if they want it done or not.

@joewiz
Copy link
Copy Markdown
Member

joewiz commented Jan 8, 2026

@daliboris Thanks, the commit is good as is. No further action necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants