add missing parentheses to %test:name() annotation#1192
add missing parentheses to %test:name() annotation#1192joewiz merged 1 commit intoeXist-db:masterfrom
Conversation
joewiz
left a comment
There was a problem hiding this comment.
Agreed. Confirmed with a search of instances of this annotation in the eXist source: https://github.com/search?q=repo%3AeXist-db%2Fexist%20%22%25test%3Aname%22&type=code. All instances include a parameter as shown here.
Annotations cannot be functions, I think you mean that the annotation has value(s) p.s. I think the title of your PR may be wrong, instead of |
|
Indeed. For the relevant portion of the spec, see https://www.w3.org/TR/xquery-31/#id-annotations. No changes to the commit's contents are needed. |
Yup, just in git the (1) commit message is misleading, (2) the merge commit message has the same problem |
|
Thank you @adamretter, I changed the title and PR message from GitHub web page. Is there an easy way to to change the merge commit message too? |
Possible yes, easy no. Probably best to discuss with the owners of this project if they want it done or not. |
|
@daliboris Thanks, the commit is good as is. No further action necessary. |
%test:name()annotation has value, so the parameter must be enclosed in parentheses.