Skip to content

Clean Code for ui/org.eclipse.pde.core#2192

Merged
HannesWell merged 2 commits intomasterfrom
clean-code/ui/org.eclipse.pde.core
Feb 28, 2026
Merged

Clean Code for ui/org.eclipse.pde.core#2192
HannesWell merged 2 commits intomasterfrom
clean-code/ui/org.eclipse.pde.core

Conversation

@eclipse-pde-bot
Copy link
Copy Markdown
Contributor

The following cleanups were applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Remove trailing white spaces on all lines
  • Remove unnecessary array creation for varargs
  • Remove unnecessary suppress warning tokens
  • Remove unused imports
  • Remove unused private constructors
  • Remove unused private fields
  • Remove unused private methods
  • Remove unused private types
  • Replace deprecated calls with inlined content where possible
  • Use pattern matching for instanceof

The following Manifest cleanups where applied:

  • Calculate 'uses' directive for public packages
  • Remove unused dependencies

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 20, 2026

Test Results

   798 files  ±0     798 suites  ±0   1h 1m 50s ⏱️ + 4m 35s
 3 787 tests ±0   3 690 ✅  - 43   54 💤 ±0  43 ❌ +43 
11 127 runs  ±0  10 963 ✅  -  1  163 💤 ±0   1 ❌ + 1 

For more details on these failures, see this check.

Results for commit d74e813. ± Comparison against base commit a624b7e.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the clean-code/ui/org.eclipse.pde.core branch from e270c57 to dbd0c4c Compare February 28, 2026 17:00
@eclipse-pde-bot
Copy link
Copy Markdown
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ui/org.eclipse.pde.core/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From f5d075a18291bbb8b5bd98748a0f727d88ae5db5 Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <pde-bot@eclipse.org>
Date: Sat, 28 Feb 2026 17:06:14 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF b/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
index 3f0faf6291..646c8b069e 100644
--- a/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
+++ b/ui/org.eclipse.pde.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %name
 Bundle-SymbolicName: org.eclipse.pde.core; singleton:=true
-Bundle-Version: 3.21.200.qualifier
+Bundle-Version: 3.21.300.qualifier
 Bundle-Activator: org.eclipse.pde.internal.core.PDECore
 Bundle-Vendor: %provider-name
 Bundle-Localization: plugin
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@HannesWell HannesWell merged commit 3555069 into master Feb 28, 2026
22 of 24 checks passed
@HannesWell HannesWell deleted the clean-code/ui/org.eclipse.pde.core branch February 28, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants