Skip to content

[GTK] Reports wrong mouse coordinates when starting a drag #2119#2574

Merged
akurtakov merged 1 commit intoeclipse-platform:masterfrom
syntevo:2119-fix-mouse-event-order
Jan 23, 2026
Merged

[GTK] Reports wrong mouse coordinates when starting a drag #2119#2574
akurtakov merged 1 commit intoeclipse-platform:masterfrom
syntevo:2119-fix-mouse-event-order

Conversation

@tmssngr
Copy link
Contributor

@tmssngr tmssngr commented Oct 1, 2025

Control: don't send MouseMove events with stateMask set for BUTTON1 before the MouseDown event was sent

These events are already added to the dragDetectionQueue, so there is no need to send/post them now.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

Test Results

  118 files  + 7    118 suites  +7   15m 15s ⏱️ - 2m 26s
4 653 tests +56  4 636 ✅ +55  17 💤 +2  0 ❌  - 1 
  338 runs  +56    334 ✅ +53   4 💤 +3  0 ❌ ±0 

Results for commit c8db974. ± Comparison against base commit 63d5582.

♻️ This comment has been updated with latest results.

@akurtakov akurtakov force-pushed the 2119-fix-mouse-event-order branch from a90eda9 to 1f4d1c0 Compare October 17, 2025 15:47
@tmssngr tmssngr force-pushed the 2119-fix-mouse-event-order branch 2 times, most recently from 366ee0e to 77b255c Compare November 5, 2025 09:59
@tmssngr tmssngr force-pushed the 2119-fix-mouse-event-order branch 2 times, most recently from 63d3ce6 to c8db974 Compare November 15, 2025 06:16
@akurtakov akurtakov force-pushed the 2119-fix-mouse-event-order branch from c8db974 to c1d8089 Compare December 9, 2025 15:04
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Test Results (linux)

   88 files  ±0     88 suites  ±0   14m 33s ⏱️ +5s
4 562 tests ±0  4 342 ✅ ±0  220 💤 ±0  0 ❌ ±0 
  211 runs  ±0    208 ✅ ±0    3 💤 ±0  0 ❌ ±0 

Results for commit b6a2e38. ± Comparison against base commit 1fe5903.

♻️ This comment has been updated with latest results.

@tmssngr tmssngr force-pushed the 2119-fix-mouse-event-order branch from c1d8089 to b5d0c9f Compare December 22, 2025 09:38
@tmssngr
Copy link
Contributor Author

tmssngr commented Jan 23, 2026

What does my PR need to get accepted?

…atform#2119

Control: don't send MouseMove events with stateMask set for BUTTON1
before the MouseDown event was sent

These events are already added to the dragDetectionQueue, so there is no
need to send/post them now.
@akurtakov akurtakov force-pushed the 2119-fix-mouse-event-order branch from b5d0c9f to b6a2e38 Compare January 23, 2026 15:01
@akurtakov
Copy link
Member

I have rebased it before christmas and it got lost in the myriad of ongoing things. It's a good patch. I've rebased it again and plan to merge it soon.
Sorry about the delay. There are less and less people spending time doing reviews.

@akurtakov akurtakov merged commit c20fea4 into eclipse-platform:master Jan 23, 2026
19 checks passed
@github-project-automation github-project-automation bot moved this to Done in SWT work Jan 23, 2026
@tmssngr
Copy link
Contributor Author

tmssngr commented Jan 23, 2026

@akurtakov I appreciate your effort. Have a nice weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants