Replacement of Image(device, int, int) constructor in examples/snippets#2827
Merged
akoch-yatta merged 1 commit intoeclipse-platform:masterfrom Jan 23, 2026
Merged
Conversation
This was
linked to
issues
Nov 28, 2025
al-noori
force-pushed
the
ReplaceImageGcDrawer
branch
from
5f66a2e to
75852df
Compare
akoch-yatta
force-pushed
the
ReplaceImageGcDrawer
branch
from
75852df to
e125f9e
Compare
Contributor
Contributor
|
I got the following difference when opening Snippet10 on a 175% monitor with master (left) and this PR (right): Didn't check the other Snippets yet. |
Contributor
That looks like an issue with |
Contributor
|
Yes, we had a look into it yesterday, but I didn't create a ticket yet. Just created #554 |
akoch-yatta
force-pushed
the
ReplaceImageGcDrawer
branch
2 times, most recently
from
db88589 to
123deb5
Compare
Almost all usages of the stated constructor with an additional GC initialization are now replaced by an ImageGcDrawer and the Image(device, gc int, int) constructor afterwards for the snippets. This replacement has/could not be made for the snippets {387, 215, 292, 95, 139} and partially not for 141.
akoch-yatta
force-pushed
the
ReplaceImageGcDrawer
branch
from
123deb5 to
f892524
Compare
akoch-yatta
approved these changes
Jan 23, 2026
Contributor
akoch-yatta
left a comment
akoch-yatta
left a comment
There was a problem hiding this comment.
LGTM, tested the snippets with the snippetexplorer. I fixed two small issues in the PR - using imageWidth instead of imageHeight. With that all snippet looked good to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR takes over a part to change all occurences of the image(device, int, int) constructor with the image(device, gc, int, int) constructor.
Within examples/snippets, almost all usages of the stated constructor are now replaced by an ImageGcDrawer and the Image(device, gc int, int) constructor afterwards. This replacement has/could not be made for the snippets {387, 215, 292, 95, 139} and partially not for 141. The details for them are commented here: vi-eclipse/Eclipse-Platform#310 (comment).