[Gtk4] Fix Shell.computeSize to take header bar into account #2895
+86
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This fixes initial size of Eclipse main window and dialogs, resizing is still broken. Fixes github.com//issues/2826 |
Contributor
Test Results (linux) 56 files - 32 56 suites - 32 10m 34s ⏱️ - 3m 50s For more details on these failures, see this check. Results for commit 137fa30. ± Comparison against base commit c891c43. This pull request removes 39 tests.♻️ This comment has been updated with latest results. |
akurtakov
force-pushed
the
master
branch
6 times, most recently
from
981eee6 to
f184dc3
Compare
akurtakov
force-pushed
the
master
branch
3 times, most recently
from
8e440a0 to
124d5e5
Compare
akurtakov
force-pushed
the
master
branch
2 times, most recently
from
43e26e1 to
9e9ba83
Compare
akurtakov
force-pushed
the
master
branch
4 times, most recently
from
5e82cc3 to
f1bb5fa
Compare
akurtakov
force-pushed
the
master
branch
2 times, most recently
from
78d05c3 to
7b7d9b9
Compare
akurtakov
force-pushed
the
master
branch
2 times, most recently
from
137fa30 to
db3bed4
Compare
HeaderBar is part of the regular window size in Gtk 4 on Wayland BUT gtk_window_get_headerbar returns 0 if it is not set by the application but drawn internally by Gtk itself and thus it's size can not be queried. Add a "default" GtkHeaderBar explicitly for that and take its size into account when computing Shell size. Mark CTabFolder test_iconWrappedOnNextLine test as gtk4-todo to allow to progress now.
Contributor
Test Results 173 files - 3 173 suites - 3 25m 33s ⏱️ - 3m 16s Results for commit 413bded. ± Comparison against base commit c891c43. This pull request removes 1 test.This pull request skips 1 test. |
Member
Author
|
Merging to be able to continue with more noticeable problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeaderBar is part of the regular window size in Gtk 4 on Wayland BUT gtk_window_get_headerbar returns 0 if it is not set by the application but drawn internally by Gtk itself and thus it's size can not be queried. Add a "default" GtkHeaderBar explicitly for that and take its size into account when computing Shell size.