Skip to content

[Win32] Silence deprecation warnings in Accessibility#3365

Merged
HeikoKlare merged 1 commit into
eclipse-platform:masterfrom
HeikoKlare:win32-accessibility-warnings
Jun 12, 2026
Merged

[Win32] Silence deprecation warnings in Accessibility#3365
HeikoKlare merged 1 commit into
eclipse-platform:masterfrom
HeikoKlare:win32-accessibility-warnings

Conversation

@HeikoKlare

@HeikoKlare HeikoKlare commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Caption and summary for a table are provided via deprecated methods for almost two decades. Since there was not attempt and need to replace those methods with proper implementations yet, so that the warnings do not produce any reasonable insights, this change silences them. In case the deprecated methods are replaced, the callers need to be adapted anyway as the SWT code will otherwise not compile anymore.

Methods deprecated in 2017 via bd447c3

image image

@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Test Results (win32)

   31 files  ±0     31 suites  ±0   4m 55s ⏱️ +34s
4 704 tests ±0  4 629 ✅ ±0  75 💤 ±0  0 ❌ ±0 
1 234 runs  ±0  1 210 ✅ ±0  24 💤 ±0  0 ❌ ±0 

Results for commit 91f6915. ± Comparison against base commit 632895d.

♻️ This comment has been updated with latest results.

@HeikoKlare HeikoKlare marked this pull request as ready for review June 4, 2026 12:01
@HeikoKlare HeikoKlare force-pushed the win32-accessibility-warnings branch 2 times, most recently from 3809899 to a7d2fdb Compare June 12, 2026 10:46
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Test Results (linux)

   97 files  ±0     97 suites  ±0   14m 55s ⏱️ -44s
4 604 tests ±0  4 380 ✅ ±0  224 💤 ±0  0 ❌ ±0 
3 404 runs  ±0  3 329 ✅ ±0   75 💤 ±0  0 ❌ ±0 

Results for commit 91f6915. ± Comparison against base commit 632895d.

♻️ This comment has been updated with latest results.

Caption and summary for a table are provided via deprecated methods for
almost a decade. Since there was not attempt and need to replace
those methods with proper implementations yet, so that the warnings do
not produce any reasonable insights, this change silences them. In case
the deprecated methods are replaced, the callers need to be adapted
anyway as the SWT code will otherwise not compile anymore.
@HeikoKlare HeikoKlare force-pushed the win32-accessibility-warnings branch from a7d2fdb to 91f6915 Compare June 12, 2026 12:27
@HeikoKlare HeikoKlare merged commit 36867ef into eclipse-platform:master Jun 12, 2026
21 checks passed
@HeikoKlare HeikoKlare deleted the win32-accessibility-warnings branch June 12, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant