Set default SVG color to match the SWT.COLOR_WIDGET_FOREGROUND#3400
Set default SVG color to match the SWT.COLOR_WIDGET_FOREGROUND#3400DLTKJoelJohansson wants to merge 1 commit into
Conversation
|
Cant get the build run locally, and jenkins reporting build errors, maybe someone can take a look? Thanks |
|
Don't do merge commits; we can't merge this into master in the end because we don't accept merge commits. In fact don't do multiple commits in general. Use rebase. Amend you commit and force push it when you need to make subsequent follow up changes. You'll need to rebase and force push to repair this PR. |
|
I'll approve the workflow so you can see any errors in the GitHub actions. Please rebase and force push to get this back on track. |
|
See we even fail with a check for merge commits: 
|
DLTKJoelJohansson
force-pushed
the
svg-fg-color
branch
from
a2d55a0 to
e05c477
Compare
|
I've approved the workflow again. I'll be out of office for a few hours... |
DLTKJoelJohansson
force-pushed
the
svg-fg-color
branch
from
e05c477 to
952e38e
Compare
|
Cant seem to figure it out, its failing for Linux builds |
DLTKJoelJohansson
force-pushed
the
svg-fg-color
branch
2 times, most recently
from
8aa4474 to
34c413c
Compare
|
Okay got it to work now! Moved out the Display.getDefault() call to org.eclipse.swt bundle (In SVGFileFormat, the caller) fixed it. Thanks @merks for your help. Let me know what you think |
|
Maybe not, seems like the Browser tests for Windows are failing. Pretty strange |
|
@merks any thoughts on this? I have a hard time seeing how these changes can cause the Browser tests to fail on Windows, since the changes only touch the SVG Rasterization |
|
It could just be a flaky test. I'll rerun it. |
|
Looks like the same Browser tests are failing again, but at least the build succeeded now |
|
I've not looked closely, but is the failure of the browser test on Windows related to this PR or maybe known to be flaky? |
|
Thanks @HeikoKlare, and @merks! This PR should ready for review now |
|
I will leave it to someone qualified to review the changes. |
3 participants
An attempt at fixing #3398.
Let me know what you think.
Thanks!