Smart Import: offer to open/show already-imported projects#4170
Open
deepika-u wants to merge 1 commit into
Open
Smart Import: offer to open/show already-imported projects#4170deepika-u wants to merge 1 commit into
deepika-u wants to merge 1 commit into
Conversation
b892066 to
53f5c94
Compare
Contributor
Contributor
Author
|
@merks : When you get some time, can you review this please? |
53f5c94 to
f8085f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Smart Import found a folder that was already imported as a project, it greyed out the row and silently ignored any attempt to check it - no explanation, no way forward. Users had to abandon the wizard just to go interact with a project that was already sitting right there in the workspace.
That row is still greyed out and still can't be selected for import - that part is correct and unchanged.
Fixes eclipse-platform/eclipse.platform#1978
What's now
Now that it's no longer a dead end:
Additionally,
The wizard also gets out of your way on its own: if the project you just acted on was the only thing selected, the wizard closes for you automatically. If other projects are still queued up for import, it stays open so that you can finish the job.
What's different for the user
yourself manually.
dismissed manually.
Scope
Only applies to projects matching by location - i.e. the exact project is already imported. Projects that merely collide by name (different folder, same project name) are untouched and keep their existing silent-exclusion behavior.
Implementation notes
isExistingProjectnow delegates to a newfindExistingProject, which returns the actual matchingIProjectinstead of just a boolean, so the checkbox handler has something to act on.asyncExec- this lets the current checkbox-event callback finishcleanly before the wizard container is torn down, rather than closing the shell out from under its own event loop.
Before pr
After pr
Once the user clicks on "Show In Project Explorer", focus is shifted to the new project.

Once the user clicks on "Open Project", project is opened and focused on.

Once the user clicks on "Show In Project Explorer", focus is shifted to the project but wizard continues to retain so that other project can be imported when "Finish" is clicked on.

Once the user clicks on "Open Project", focus is shifted to the opened project but wizard continues to retain so that other project can be imported when "Finish" is clicked on.
