Run terminal tests with the UI test harness#2766
Merged
vogella merged 1 commit intoJun 12, 2026
Merged
Conversation
The terminal test suite now contains TerminalsViewReorderTest, which loads the TerminalsView class from org.eclipse.terminal.view.ui. Lazily activating that bundle fails in the headless core-test harness because UIPlugin.start() registers a workbench listener, which requires a running workbench. The SDK I-builds therefore reported 5 test failures, while the Tycho build, which auto-detects the UI harness, stayed green. Run the suite via the ui-test target so a workbench is available, matching the other UI test bundles in this repository. Fixes eclipse-platform#2762
Contributor
|
Seems like a proper correction of consistency. Because fwiw, this statement is not correct:
There is no auto-detection but the UI harness was explicitly set for the test bundle in the PR introducing the tests: |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #2681 the terminal test suite contains TerminalsViewReorderTest, which loads the TerminalsView class and thereby lazily activates org.eclipse.terminal.view.ui. That activation fails in the headless core-test harness used by the SDK I-builds because UIPlugin.start() registers a workbench listener, causing the 5 failures reported in #2762. The Tycho build stayed green because it auto-detects the UI harness for this bundle and already runs the whole suite with a workbench.
This switches the test.xml suite target from core-test to ui-test so the SDK builds get the same environment, matching the other UI test bundles in this repository.
Fixes #2762