Add N&N on Equinox launcher and SWT monitor-specific scaling defaults#480
Merged
HeikoKlare merged 1 commit intoeclipse-platform:masterfrom Jan 26, 2026
Conversation
a2a672e to
95dd008
Compare
danthe1st
reviewed
Jan 23, 2026
news/4.39/platform.md
Outdated
| To work properly, this requires the DPI awareness "PerMonitorV2", which is set by SWT for the UI thread automatically. | ||
| The Equinox launcher executable still contained a manifest that defines a DPI awareness of "System" for the process. | ||
|
|
||
| By now, this led to the splash screen not properly being scaled and to potentially incorrect results at the handover of the splash screen to SWT and the Platform Workbench. |
Contributor
There was a problem hiding this comment.
Should this really be "By now" or would "Until now" be better?
Contributor
There was a problem hiding this comment.
Not just better, but actually correct. 😁
Contributor
Author
There was a problem hiding this comment.
Thank you! That makes the news correct and my English better 🙂
Seems like I only failed once with that wording in another news:
akoch-yatta
approved these changes
Jan 26, 2026
Contributor
akoch-yatta
left a comment
There was a problem hiding this comment.
LGTM, only a short remark
95dd008 to
ef3a47d
Compare
# Conflicts: # news/4.39/platform.md
ef3a47d to
4b995cb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SWT:
Equinox: