Skip to content

fix: Update bazel cache on "merge_group" event#97

Open
NEOatNHNG wants to merge 1 commit intomainfrom
NEOatNHNG/issue95
Open

fix: Update bazel cache on "merge_group" event#97
NEOatNHNG wants to merge 1 commit intomainfrom
NEOatNHNG/issue95

Conversation

@NEOatNHNG
Copy link
Copy Markdown

Fixes #95

@lurtz
Copy link
Copy Markdown
Contributor

lurtz commented Apr 15, 2026

Can you along the way also check why caches are not saved in pull requests?

One example https://github.com/eclipse-score/inc_someip_gateway/actions/runs/24330218768/job/71034147474#step:5:98 from eclipse-score/inc_someip_gateway#60

Copy link
Copy Markdown
Author

@NEOatNHNG NEOatNHNG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you along the way also check why caches are not saved in pull requests?

One example https://github.com/eclipse-score/inc_someip_gateway/actions/runs/24330218768/job/71034147474#step:5:98 from eclipse-score/inc_someip_gateway#60

See #56

That was a concious decision so that the cache is not "polluted" with stuff that is only existing on a branch. The idea usually is that a feature branch would normally use 90% of the stuff from main, so it is most efficient if the cache contains the stuff from main and then for each PR build most of the stuff from the cache can be re-used. If the cache also gets filled with stuff from the feature branches then it could happen that stuff from the feature branch evicts main stuff from the cache so the cache content fits better to that PR but less to the content of other PRs.
At least that is what I assume was the reasoning why to use cache-save: ${{ github.event_name == 'push' }} in the first place.

@lurtz
Copy link
Copy Markdown
Contributor

lurtz commented Apr 15, 2026

I see, but something is not working as expected. I never saw cache hits for workflows running in pull requests.

@lurtz
Copy link
Copy Markdown
Contributor

lurtz commented Apr 15, 2026

now I found a cache hit in a pull request: https://github.com/eclipse-score/inc_someip_gateway/actions/runs/24464232742/job/71486694945#step:5:114

Maybe I was wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

QNX workflow often fails to download SDP: Connect timed out

2 participants