hmon: add logic monitor by arkjedrz · Pull Request #95 · eclipse-score/lifecycle

arkjedrz · 2026-02-27T11:50:54Z

Add logic monitor to HMON.

Resolved #96

- Fix Cargo for `health_monitoring_lib`. - Fix leftover test changes from previous PR. - Small code changes.

- Less restrictive feature flags. - Additional small code changes.

- Remove unnecessary abstraction from monitors. - Improve docs. - Move `FFIBorrowed` and `FFIHandle` to main `ffi` module. - Small esthetics fixes.

- Restore some parts. - Separate errors into groups.

- Add `HealthMonitorError`. - Not fully utilized in this change, required for future monitors. - Simplify implementation of `start` and `build`. - No longer must be reimplemented for FFI. - New unit tests for `lib.rs`.

Add heartbeat monitor HMON.

Add C++ interface to heartbeat monitor.

Add logic monitor to HMON.

github-actions · 2026-02-27T11:51:38Z

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run //:license-check

Status: ⚠️ Needs Review

Click to expand output

[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: cd542567-d492-4cd6-abbb-59fdb8e44ccd
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
WARNING: For repository 'score_rust_policies', the root module requires module version score_rust_policies@0.0.3, but got score_rust_policies@0.0.5 in the resolved dependency graph. Please update the version in your MODULE.bazel or set --check_direct_dependencies=off
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (33 packages loaded, 9 targets configured)

Analyzing: target //:license-check (75 packages loaded, 9 targets configured)

Analyzing: target //:license-check (85 packages loaded, 9 targets configured)

Analyzing: target //:license-check (135 packages loaded, 2384 targets configured)

Analyzing: target //:license-check (149 packages loaded, 4441 targets configured)

Analyzing: target //:license-check (155 packages loaded, 7768 targets configured)

Analyzing: target //:license-check (160 packages loaded, 7814 targets configured)

Analyzing: target //:license-check (160 packages loaded, 7817 targets configured)

Analyzing: target //:license-check (160 packages loaded, 7817 targets configured)

INFO: Analyzed target //:license-check (165 packages loaded, 9955 targets configured).
[1 / 1] no actions running
[13 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 1s disk-cache, processwrapper-sandbox
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 27.280s, Critical Path: 2.79s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Copilot

Pull request overview

This PR extends the health monitoring library with new monitor types (heartbeat + logic) and refactors the worker/supervisor client plumbing so the worker can evaluate multiple monitor kinds and report typed evaluation errors across Rust + C++/FFI.

Changes:

Add new HeartbeatMonitor (state + evaluator + FFI + C++ wrapper) and LogicMonitor (state-transition validator).
Refactor monitor evaluation to pass an HMON starting Instant and to report typed MonitorEvaluationError variants (deadline/heartbeat/logic).
Move supervisor API client implementations into a feature-gated supervisor_api_client/ module and adjust build config defaults/features.

Reviewed changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/health_monitoring_lib/rust/worker.rs	Updates monitoring loop to pass a shared starting `Instant` and log typed monitor errors; removes in-file supervisor client impls.
src/health_monitoring_lib/rust/tag.rs	Adds `StateTag` newtype for logic monitor states; updates tag tests.
src/health_monitoring_lib/rust/supervisor_api_client/stub_supervisor_api_client.rs	Adds stub supervisor client implementation behind feature gate.
src/health_monitoring_lib/rust/supervisor_api_client/score_supervisor_api_client.rs	Adds SCORE supervisor client implementation (monitor_rs-backed).
src/health_monitoring_lib/rust/supervisor_api_client/mod.rs	Introduces `SupervisorAPIClient` trait and feature-gated implementations.
src/health_monitoring_lib/rust/logic/mod.rs	Adds logic module exports.
src/health_monitoring_lib/rust/logic/logic_monitor.rs	Implements logic monitor state machine + evaluator + tests.
src/health_monitoring_lib/rust/lib.rs	Integrates deadline/heartbeat/logic monitors into `HealthMonitorBuilder` + `HealthMonitor`; changes build/start to return `Result`.
src/health_monitoring_lib/rust/heartbeat/mod.rs	Adds heartbeat module wiring and FFI submodule.
src/health_monitoring_lib/rust/heartbeat/heartbeat_state.rs	Adds compact atomic heartbeat state representation (+ loom-aware atomics).
src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs	Adds heartbeat monitor implementation + builder validation + tests.
src/health_monitoring_lib/rust/heartbeat/ffi.rs	Adds FFI for heartbeat monitor builder/monitor and tests.
src/health_monitoring_lib/rust/ffi.rs	Extends core FFI to build/start using `Result`, adds heartbeat builder/get FFI, and maps `HealthMonitorError` to `FFICode`.
src/health_monitoring_lib/rust/deadline/mod.rs	Re-exports `DeadlineEvaluationError` for typed evaluation errors.
src/health_monitoring_lib/rust/deadline/deadline_monitor.rs	Refactors deadline monitor to use typed `DeadlineEvaluationError` and updated evaluator signature.
src/health_monitoring_lib/rust/common.rs	Introduces `HasEvalHandle`, typed `MonitorEvaluationError`, shared evaluation signature, and time conversion helpers.
src/health_monitoring_lib/cpp/tests/health_monitor_test.cpp	Extends C++ test to build/get/use heartbeat monitor.
src/health_monitoring_lib/cpp/include/score/hm/heartbeat/heartbeat_monitor.h	Adds C++ API surface for heartbeat monitor + builder.
src/health_monitoring_lib/cpp/include/score/hm/health_monitor.h	Adds heartbeat monitor APIs to C++ `HealthMonitor(Builder)`.
src/health_monitoring_lib/cpp/heartbeat_monitor.cpp	Implements C++ heartbeat monitor wrapper calling Rust FFI.
src/health_monitoring_lib/cpp/health_monitor.cpp	Wires heartbeat builder/get calls through Rust FFI.
src/health_monitoring_lib/Cargo.toml	Adds features (default stub; optional score uses monitor_rs) and loom dependency config.
src/health_monitoring_lib/BUILD	Adds heartbeat C++ sources/headers and adjusts crate feature flags for Bazel targets.
examples/rust_supervised_app/src/main.rs	Updates example to handle `build()`/`start()` returning `Result`.
Cargo.toml	Sets workspace `default-members` and adds `cfg(loom)` lint configuration.
Cargo.lock	Adds new dependency entries (loom + transitive deps).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-27T11:56:01Z

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs

+        let internal_processing_cycle_ms = internal_processing_cycle.as_millis() as u64;
+        if range_min_ms * 2 <= internal_processing_cycle_ms {
+            error!(
+                "Internal processing cycle duration ({} ms) must be longer than two shortest allowed ranges ({} ms).",


The validation condition rejects large internal processing cycles, but the logged error message says the internal processing cycle "must be longer" than the allowed ranges. This is contradictory to the check and will confuse users when diagnosing invalid configurations. Please update the message (or the check) so they describe the same rule (e.g., that the internal processing cycle must be sufficiently short relative to the minimum heartbeat range).

Suggested change

"Internal processing cycle duration ({} ms) must be longer than two shortest allowed ranges ({} ms).",

"Internal processing cycle duration ({} ms) must be shorter than twice the shortest allowed range (2 × {} ms).",

Copilot · 2026-02-27T11:56:01Z

src/health_monitoring_lib/rust/heartbeat/heartbeat_monitor.rs

+impl InternalRange {
+    /// Create range using provided values.
+    fn new(min: u32, max: u32) -> Self {
+        assert!(min <= max, "provided min is greater than provided max");


InternalRange::new uses an assert!(min <= max, ...), which can panic from user-provided TimeRange values (including via FFI). Since the public APIs in this crate are moving toward returning Result/error codes instead of panicking, consider validating the range and returning HealthMonitorError::InvalidArgument rather than asserting.

Suggested change

assert!(min <= max, "provided min is greater than provided max");

if min > max {

error!(

"InternalRange::new called with invalid range: min ({}) > max ({})",

min, max

);

// Fall back to a zero-length range at `min` to avoid panicking on invalid input.

return Self { min, max: min };

}

Copilot · 2026-02-27T11:56:02Z

src/health_monitoring_lib/rust/logic/logic_monitor.rs

+        match value {
+            value if value == LogicEvaluationError::InvalidState as u8 => LogicEvaluationError::InvalidState,
+            value if value == LogicEvaluationError::InvalidTransition as u8 => LogicEvaluationError::InvalidTransition,
+            _ => panic!("Invalid underlying value of logic evaluation error."),


impl From<u8> for LogicEvaluationError panics on unknown values. Since this conversion is used when interpreting AtomicU8 state during evaluate, an unexpected value would crash the monitoring thread/process instead of reporting an error. Please make this conversion non-panicking (e.g., map unknown values to InvalidState or return Option/Result) and handle that path in evaluate.

Suggested change

_ => panic!("Invalid underlying value of logic evaluation error."),

_ => LogicEvaluationError::InvalidState,

Copilot · 2026-02-27T11:56:02Z

src/health_monitoring_lib/rust/supervisor_api_client/score_supervisor_api_client.rs

+unsafe impl Send for ScoreSupervisorAPIClient {} // Just assuming it's safe to send across threads, this is a temporary solution
+


unsafe impl Send for ScoreSupervisorAPIClient is currently justified only by a comment (“just assuming it's safe”). If monitor_rs::Monitor<Checks> is not actually thread-safe, this is unsound and can lead to undefined behavior when the client is moved to the worker thread. Please either remove the unsafe impl Send (and adjust the design) or document and enforce the invariants that make it sound (e.g., prove monitor_rs::Monitor<Checks> is Send/thread-safe or wrap access behind synchronization).

Suggested change

unsafe impl Send for ScoreSupervisorAPIClient {} // Just assuming it's safe to send across threads, this is a temporary solution

Copilot · 2026-02-27T11:56:02Z

src/health_monitoring_lib/rust/lib.rs

+        // Should never occur if created by `HealthMonitorBuilder`!
+        let num_monitors = self.deadline_monitors.len() + self.heartbeat_monitors.len() + self.logic_monitors.len();
+        if num_monitors == 0 {
+            error!("No monitors have been added. HealthMonitor cannot be created.");


This log message is emitted from HealthMonitor::start, but says the monitor "cannot be created". Consider changing it to "cannot be started" (or similar) so error logs reflect the operation that failed.

Suggested change

error!("No monitors have been added. HealthMonitor cannot be created.");

error!("No monitors have been added. HealthMonitor cannot be started.");

Copilot · 2026-02-27T11:56:02Z

src/health_monitoring_lib/rust/heartbeat/heartbeat_state.rs

+        assert!(value < 1 << 29, "provided heartbeat offset is out of range");
+        self.0 = ((value as u64) << BEAT_OFFSET) | (self.0 & !BEAT_MASK);


set_heartbeat_timestamp_offset uses an assert! for the 29-bit limit, which will panic if a heartbeat arrives after a long delay (e.g., if now - start_ts exceeds ~6 days in ms). Since this can be triggered by runtime conditions, consider handling overflow gracefully (e.g., clamp/saturate, reset cycle state, or return/report an error) rather than panicking.

Suggested change

assert!(value < 1 << 29, "provided heartbeat offset is out of range");

self.0 = ((value as u64) << BEAT_OFFSET) | (self.0 & !BEAT_MASK);

let clamped = min(value, (1 << 29) - 1);

self.0 = ((clamped as u64) << BEAT_OFFSET) | (self.0 & !BEAT_MASK);

github-actions · 2026-02-27T11:58:49Z

The created documentation from the pull request is available at: docu-html

arkjedrz added 8 commits February 25, 2026 08:55

hmon: fix Cargo build, small code changes

3cb438a

- Fix Cargo for `health_monitoring_lib`. - Fix leftover test changes from previous PR. - Small code changes.

hmon: Cargo fix post-review fixes

35c7c0d

- Less restrictive feature flags. - Additional small code changes.

hmon: approach to monitors rework

168d203

- Remove unnecessary abstraction from monitors. - Improve docs. - Move `FFIBorrowed` and `FFIHandle` to main `ffi` module. - Small esthetics fixes.

hmon: approach to monitors rework

c85301c

- Restore some parts. - Separate errors into groups.

hmon: rework behavior on panics

aa819a8

- Add `HealthMonitorError`. - Not fully utilized in this change, required for future monitors. - Simplify implementation of `start` and `build`. - No longer must be reimplemented for FFI. - New unit tests for `lib.rs`.

hmon: add heartbeat monitor

a1e6154

Add heartbeat monitor HMON.

hmon: add C++ interface to heartbeat monitor

602b860

Add C++ interface to heartbeat monitor.

hmon: add logic monitor

38a2bdf

Add logic monitor to HMON.

arkjedrz requested review from Copilot and pawelrutkaq February 27, 2026 11:50

arkjedrz self-assigned this Feb 27, 2026

arkjedrz had a problem deploying to workflow-approval February 27, 2026 11:50 — with GitHub Actions Failure

arkjedrz had a problem deploying to workflow-approval February 27, 2026 11:50 — with GitHub Actions Error

Copilot started reviewing on behalf of arkjedrz February 27, 2026 11:51 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hmon: add logic monitor#95

hmon: add logic monitor#95
arkjedrz wants to merge 8 commits intoeclipse-score:mainfrom
qorix-group:arkjedrz_logic-monitor

arkjedrz commented Feb 27, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	"Internal processing cycle duration ({} ms) must be longer than two shortest allowed ranges ({} ms).",
	"Internal processing cycle duration ({} ms) must be shorter than twice the shortest allowed range (2 × {} ms).",

-        assert!(min <= max, "provided min is greater than provided max");
+        if min > max {
+            error!(
+                "InternalRange::new called with invalid range: min ({}) > max ({})",
+                min, max
+            );
+            // Fall back to a zero-length range at `min` to avoid panicking on invalid input.
+            return Self { min, max: min };
+        }

	_ => panic!("Invalid underlying value of logic evaluation error."),
	_ => LogicEvaluationError::InvalidState,

		unsafe impl Send for ScoreSupervisorAPIClient {} // Just assuming it's safe to send across threads, this is a temporary solution

	error!("No monitors have been added. HealthMonitor cannot be created.");
	error!("No monitors have been added. HealthMonitor cannot be started.");

		assert!(value < 1 << 29, "provided heartbeat offset is out of range");
		self.0 = ((value as u64) << BEAT_OFFSET) \| (self.0 & !BEAT_MASK);

Conversation

arkjedrz commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Feb 27, 2026

License Check Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

arkjedrz commented Feb 27, 2026 •

edited

Loading