Skip to content

add documentation examples#58

Open
RolandJentschETAS wants to merge 18 commits intomainfrom
improvement_add_documentation_examples
Open

add documentation examples#58
RolandJentschETAS wants to merge 18 commits intomainfrom
improvement_add_documentation_examples

Conversation

@RolandJentschETAS
Copy link
Copy Markdown
Contributor

@RolandJentschETAS RolandJentschETAS commented Apr 1, 2026

Move the documentation examples from process documentation to module template.

See belonging PR eclipse-score/process_description#632 in process.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.3.0) and connecting to it...
INFO: Invocation ID: 372bf7f1-ccc0-4eeb-a045-0ff96a7f1f4c
Computing main repo mapping: 
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (27 packages loaded, 9 targets configured)

Analyzing: target //:license-check (81 packages loaded, 9 targets configured)

Analyzing: target //:license-check (90 packages loaded, 9 targets configured)

Analyzing: target //:license-check (133 packages loaded, 1517 targets configured)

Analyzing: target //:license-check (154 packages loaded, 4815 targets configured)

Analyzing: target //:license-check (158 packages loaded, 7650 targets configured)

Analyzing: target //:license-check (161 packages loaded, 7660 targets configured)

Analyzing: target //:license-check (161 packages loaded, 7660 targets configured)

Analyzing: target //:license-check (161 packages loaded, 7660 targets configured)

Analyzing: target //:license-check (164 packages loaded, 9544 targets configured)

Analyzing: target //:license-check (164 packages loaded, 9545 targets configured)

Analyzing: target //:license-check (164 packages loaded, 9545 targets configured)

Analyzing: target //:license-check (165 packages loaded, 9669 targets configured)

Analyzing: target //:license-check (166 packages loaded, 9789 targets configured)

Analyzing: target //:license-check (166 packages loaded, 9789 targets configured)

INFO: Analyzed target //:license-check (167 packages loaded, 11724 targets configured).
[9 / 16] Creating runfiles tree bazel-out/k8-opt-exec-ST-d57f47055a04/bin/external/score_tooling+/dash/tool/formatters/dash_format_converter.runfiles [for tool]; 0s local ... (2 actions, 1 running)
[12 / 16] JavaToolchainCompileClasses external/rules_java+/toolchains/platformclasspath_classes; 1s disk-cache, processwrapper-sandbox ... (2 actions running)
INFO: From Generating Dash formatted dependency file ...:
INFO: Successfully converted 2 packages from Cargo.lock to bazel-out/k8-fastbuild/bin/formatted.txt
[14 / 16] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar; 0s disk-cache, processwrapper-sandbox
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 205.352s, Critical Path: 2.90s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

The created documentation from the pull request is available at: docu-html

Placeholder for the description that will be generated from doxygen
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We aren't using doxygen, is this a typo / old copy paste error?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description itself is directly moved from process description. Maybe the process description was wrong.

# SPDX-License-Identifier: Apache-2.0
# *******************************************************************************

.. include:: ../../../score/example_component/docs/component_architecture_template.rst
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this, can you explain?
Why is this included and not just in one place?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the documentation guidelines the component documentation is located nearby the components. That means in the docs folder of the component. If I want to refer to that from the architecture I have to link it in this way.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how to solve different parts in one repo in an other way. Maybe by an index.rst at top level.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There currently isn't a way to have different TOP LEVEL doc folders. They all have to be in a single combined folder.

Copy link
Copy Markdown
Contributor Author

@RolandJentschETAS RolandJentschETAS Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or (as is shown here) it is linked in this way. I really prefer to have the documentation directly in the near of the sourcecode. Otherwise (this is really my experience from any previous project) it will not be maintained by the developers, because it is out of their local focus.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is an issue of the maintainers / codeowners of the repo. They have to define that behaviour and how it is handled in repo. In my opinion it makes the most sense to have them enforce the documentation is kept up to date otherwise the feature should not be merged. Though unsure. @AlexanderLanin @masc2023 do we know if there is any written record of this somewhere ? I couldn''t find it in my search.

You mean about "There currently isn't a way to have different TOP LEVEL doc folders. They all have to be in a single combined folder."
I am not aware about any DR about that topic

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isnt that what any_folder is for?

Any folder was reverted in the newest docs-as-code release, as it broke ref-integration if used and was fundamentally not fixable in a reasonable amount of time with the chosen approach

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the meaning of "any_folder" ?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally I'm not sure if there is any issue. There is the possibility with the include. Or via an additional path. See https://www.sphinx-doc.org/en/master/usage/configuration.html#confval-include_patterns

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to main index.rst in main folder with include path.

| `score/` | Source files and Unit Tests for the module |
| `tests/` | Component and Feature Integration Tests (CIT&FIT) |
| `examples/` | Example files used for guidance |
| `docs/` | Documentation (Doxygen for C++ / mdBook for Rust) |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I know doxygen is not used currently.
OR am I on old information?

Copy link
Copy Markdown
Contributor Author

@RolandJentschETAS RolandJentschETAS Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unchanged (was there also before PR). We have to check that.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation process is not finalised yet, that was planned for implementation, detailed design

@arsibo
Copy link
Copy Markdown

arsibo commented Apr 2, 2026

After discussion with Roland and the discussion in the process meeting (02.04.2026)
We will prepare a DR. We discussed the point in January , but haven't finalized it yet (#40)

In case that the new DR can not be decided in the next two weeks, we need a workaround step for that PR.
Maybe we can do it as intermediate solution.

@aschemmel-tech
Copy link
Copy Markdown

aschemmel-tech commented Apr 2, 2026

The folder structure already documented in https://eclipse-score.github.io/score/main/contribute/general/folder.html#module-folder-structure does not have the problem as I understand (the entry point for sphinx would be <module_name> folder). Why not use this? But I understand that we would not like to have a path which is like https://github.com/eclipse-score/<repository_name>/<module_name> because these may be the same, but please consider that we defined "This Delivery Container can contain one or more Dependable Elements" in https://eclipse-score.github.io/process_description/main/general_concepts/score_building_blocks_concept.html so a reposity could contain more than one module.

Copy link
Copy Markdown

@aschemmel-tech aschemmel-tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comments

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated AoUs from component and feature sections. Why?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rename the folder this resides in to "architecture_example" or "example" as also the feature architecture templates will come here and should be in a folder called "architecture"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also here, rather call the folder and headline "verification" as the feature integration test templates may also move here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

6 participants