[rules score] fix architecture validation - #383
Merged
Conversation
hoe-jo
commented
Jul 30, 2026
hoe-jo
commented
Contributor
- fix a bug where an empty component did not show any warning, now a component needs either another nested component or a unit
hoe-jo
requested review from
LittleHuba,
castler,
limdor and
ramceb
as code owners
July 30, 2026 14:39
hoe-jo
force-pushed
the
joho_treat_empty_component_as_error
branch
3 times, most recently
from
August 10, 2026 07:57
edd345c to
d568eee
Compare
- fix a bug where an empty component did not show any warning, now a component needs either another nested component or a unit
hoe-jo
force-pushed
the
joho_treat_empty_component_as_error
branch
from
August 10, 2026 08:12
d568eee to
deababb
Compare
LittleHuba
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.