Skip to content

fix: tolerate sigpipe truncating large ai review diffs #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
margaretjgu wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix: tolerate sigpipe truncating large ai review diffs #547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ai-pr-review-external.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
GH_REPO: ${{ github.repository }}
PR_NUMBER: ${{ github.event.issue.number }}
run: |
gh pr diff "$PR_NUMBER" | head -c 32000 > /tmp/diff.txt
gh pr diff "$PR_NUMBER" | head -c 32000 > /tmp/diff.txt || true

- name: Review
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ai-pr-review.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ jobs:
echo "Reviewing changes since previous review ($PREV_SHA)"
echo "incremental" > /tmp/review_mode.txt
gh api "repos/${GH_REPO}/compare/${PREV_SHA}...${HEAD_SHA}" \
-H "Accept: application/vnd.github.v3.diff" | head -c 32000 > /tmp/diff.txt
-H "Accept: application/vnd.github.v3.diff" | head -c 32000 > /tmp/diff.txt || true
else
echo "No prior review found, reviewing full PR diff"
echo "full" > /tmp/review_mode.txt
gh pr diff "$PR_NUMBER" | head -c 32000 > /tmp/diff.txt
gh pr diff "$PR_NUMBER" | head -c 32000 > /tmp/diff.txt || true
fi

- name: Review
Expand Down
Loading