fix(types): widen boolean serializer to accept number and string coercions#952
Open
claygeo wants to merge 1 commit intoelectric-sql:mainfrom
Open
fix(types): widen boolean serializer to accept number and string coercions#952claygeo wants to merge 1 commit intoelectric-sql:mainfrom
claygeo wants to merge 1 commit intoelectric-sql:mainfrom
Conversation
…cions
Previously the boolean serializer threw for any non-boolean input,
causing UPDATE statements with JS truthy values (1, 0, "true", "false")
to error unexpectedly. PostgreSQL accepts these coercions natively.
Widen the serialize signature to boolean | number | string:
- Strings: matches PostgreSQL's accepted true literals
('true', 't', '1', 'yes', 'on') case-insensitively
- Numbers / booleans: coerced via truthiness (1 -> 't', 0 -> 'f')
Fixes: electric-sql#791
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The boolean type serializer currently throws for any non-
booleaninput:JavaScript often represents booleans as
1/0or"true"/"false"(from form inputs, JSON APIs, etc.). Passing these to an UPDATE statement causes an unexpected runtime error.Fixes #791
Fix
Widen the serializer to accept
boolean | number | string, matching PostgreSQL's own boolean casting rules:true,t,1,yes,on). Everything else serializes to'f'(matchingfalse,f,0,no,off).1 → 't',0 → 'f').Tests
Added 10 serializer tests covering all input types and boundaries.