Skip to content

Dockerfile: Rebase on Flathub actions image#234

Merged
ryonakano merged 1 commit into
mainfrom
ryonakano/dockerfile-rebase-on-flathub-actions-image
May 3, 2026
Merged

Dockerfile: Rebase on Flathub actions image#234
ryonakano merged 1 commit into
mainfrom
ryonakano/dockerfile-rebase-on-flathub-actions-image

Conversation

@ryonakano
Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member

@davidmhewitt davidmhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

Any reason this is still in draft?

@ryonakano
Copy link
Copy Markdown
Member Author

Thanks for review!

Any reason this is still in draft?

Because I haven't confirmed whether this really fixes the linked issue, i.e. whether the .metainfo file after appstreamcli compose contains the x-appcenter keys (and I'm not sure how to do this…… 🤔)

@davidmhewitt
Copy link
Copy Markdown
Member

@ryonakano

You could run a shell inside the Docker container, and use the flatpak-builder in there to build a Flatpak with the metadata keys (you'd need to mount the app's git repo to the container). If you instruct flatpak-builder to export to a repo with:

flatpak-builder --repo=repo

After the build, it will have exported the appstream metadata. Check the commit ID on the appstream branch with:

less repo/refs/heads/appstream/x86_64

Once you have the commit ID, check it out with ostree:

sudo ostree checkout --repo repo ${COMMIT_ID}
zless ${COMMIT_ID}/appstream.xml.gz

Then you can check if the metadata is present in that appstream file.

@ryonakano
Copy link
Copy Markdown
Member Author

Thank you very much, I can confirm the generated metadata contains x-appcenter keys using my forked flatpak-platform Docker image that already merged this branch into main:

bash-5.3# grep x-appcenter $COMMIT_ID/appstream.xml
      <value key="x-appcenter-color-primary">#603461</value>
      <value key="x-appcenter-color-primary-text">rgb(255, 255, 255)</value>
      <value key="x-appcenter-stripe">pk_live_Uhb96elhovWNRGkq07m2FRO9008Ia8OtVa</value>
      <value key="x-appcenter-suggested-price">10</value>
bash-5.3#

Just leaving a note what I did as a note. First I launched my forked Docker image:

$ docker run -it --privileged --name custom-key-test -v $PWD:/workdir ghcr.io/ryonakano/flatpak-platform/runtime:8-aarch64 bash

Then I run the following commands in the container:

# flatpak-builder --disable-rofiles-fuse --repo=repo --install-deps-from=appcenter --force-clean builddir elementary/com.github.phase1geo.minder.yml
# COMMIT_ID=$(cat repo/refs/heads/appstream/$(uname -m))
# ostree checkout --repo repo $COMMIT_ID
# gunzip --keep $COMMIT_ID/appstream.xml.gz
# grep x-appcenter $COMMIT_ID/appstream.xml

@ryonakano ryonakano marked this pull request as ready for review May 3, 2026 05:52
Copy link
Copy Markdown
Member

@davidmhewitt davidmhewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ryonakano ryonakano merged commit 1553b23 into main May 3, 2026
@ryonakano ryonakano deleted the ryonakano/dockerfile-rebase-on-flathub-actions-image branch May 3, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minder and Annotator are currently listed as free apps

2 participants