Preserve resolved dehydrated Suspense content on context change#10
Open
hbrooks wants to merge 1 commit into
Open
Preserve resolved dehydrated Suspense content on context change#10hbrooks wants to merge 1 commit into
hbrooks wants to merge 1 commit into
Conversation
When a resolved dehydrated Suspense boundary contains a suspended child, a parent context change can mark the boundary as needing work during hydration. If selective hydration retries are exhausted, React would give up and replace the dehydrated subtree with a client-rendered boundary, destroying the server HTML and showing the fallback. Preserve the dehydrated fragment in this case when the boundary is resolved and the only change is context (not props). Fixes facebook#22692
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally PR facebook#35914 in facebook/react by @schiller-manuel