Skip to content

Conversation

@kerams
Copy link
Contributor

@kerams kerams commented Mar 2, 2025

Closes #98

@et1975
Copy link
Member

et1975 commented Mar 2, 2025

Thanks @kerams, it seems our builds have rotted away :/
We need to get them to passing again, would you be able to fix that as well?

@kerams
Copy link
Contributor Author

kerams commented Mar 3, 2025

Ready

@et1975 et1975 merged commit ceef058 into elmish:v4.x Mar 3, 2025
2 checks passed
@kerams kerams deleted the 19 branch March 3, 2025 13:33
@et1975
Copy link
Member

et1975 commented Mar 3, 2025

@MangelMaxime sorry, I didn't wait for your feedback, but would still like to see it.
Also not sure if we should do a major version bump, as it has breaking dependency changes.

@et1975
Copy link
Member

et1975 commented Mar 3, 2025

@kerams do you have a test project that you've tried this on?
I usually update one of the samples to use the local build of elimish/react to try it out.

@kerams
Copy link
Contributor Author

kerams commented Mar 3, 2025

I haven't tried these changes, but it's very straightforward. All I did was remove the <18 branches. A prerelease is fine if you want to be extra careful. Agree with a major bump.

@MangelMaxime
Copy link
Member

@et1975 I made a quick test locally and it seems to be working fine.

IHMO A new major release make sense, once done I will need to make a new release for Elmish.HMR too I think.

@kerams
Copy link
Contributor Author

kerams commented Mar 18, 2025

Could you make a (pre)release please?

@et1975
Copy link
Member

et1975 commented Mar 18, 2025

Created v5.x branch, will release from it later.

@et1975
Copy link
Member

et1975 commented Mar 19, 2025

released as 5.0.0-beta-2

@kerams
Copy link
Contributor Author

kerams commented Mar 22, 2025

Cheers. Works fine with React 19, HMR too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecated render and hydrate removed in React 19

3 participants