-
Notifications
You must be signed in to change notification settings - Fork 20
Remove support for React 17 #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks @kerams, it seems our builds have rotted away :/ |
|
Ready |
|
@MangelMaxime sorry, I didn't wait for your feedback, but would still like to see it. |
|
@kerams do you have a test project that you've tried this on? |
|
I haven't tried these changes, but it's very straightforward. All I did was remove the <18 branches. A prerelease is fine if you want to be extra careful. Agree with a major bump. |
|
@et1975 I made a quick test locally and it seems to be working fine. IHMO A new major release make sense, once done I will need to make a new release for Elmish.HMR too I think. |
|
Could you make a (pre)release please? |
|
Created v5.x branch, will release from it later. |
|
released as 5.0.0-beta-2 |
|
Cheers. Works fine with React 19, HMR too. |
Closes #98