Open
Conversation
aobolensk
reviewed
Mar 26, 2026
| @@ -1,12 +1,14 @@ | |||
| #pragma once | |||
| // clang-format off | |||
| } | ||
|
|
||
| #ifdef HAS_OPENMP | ||
| #ifdef _OPENMP |
| namespace parallel { | ||
|
|
||
| enum class Backend : std::uint8_t { | ||
| enum class Backend : uint8_t { |
Member
There was a problem hiding this comment.
Please, remove all unnecessary changes (since we don't have checks for all platforms). Ideally, that should be one very simple script with < 100 LoC
src/layers_oneDNN/ConcatLayer.cpp
Outdated
| @@ -1,4 +1,5 @@ | |||
| #include <cstdint> | |||
| #include <stdint.h> | |||
Member
There was a problem hiding this comment.
Same and everywhere else. Why?
aobolensk
reviewed
Mar 26, 2026
| - name: Run clang-tidy | ||
| run: | | ||
| clang-tidy app/**/*.cpp src/**/*.cpp -format-style=file -header-filter="($PWD/include/.*|$PWD/src/.*|$PWD/app/.*)" -p build | ||
| python3 - <<'PY' |
Member
There was a problem hiding this comment.
There should be no changes. app/SYCL can contain exclusions
aobolensk
reviewed
Mar 27, 2026
| - name: Run clang-tidy | ||
| run: | | ||
| clang-tidy app/**/*.cpp src/**/*.cpp -format-style=file -header-filter="($PWD/include/.*|$PWD/src/.*|$PWD/app/.*)" -p build | ||
| mapfile -t sources < <(find app src -path 'app/SYCL' -prune -o -name '*.cpp' -print) |
| concat_connections[layer_name].push_back(base_input_name); | ||
| } | ||
| } | ||
| auto concat_layer = LayerFactory::createConcatLayer(axis, options); |
| #include "layers/Tensor.hpp" | ||
| #include "layers/TransposeLayer.hpp" | ||
| #include "layers_oneDNN/BinaryOpLayer.hpp" | ||
| #include "layers_oneDNN/ConcatLayer.hpp" |
| @@ -1,30 +1,216 @@ | |||
| include(ExternalProject) | |||
Member
There was a problem hiding this comment.
These changes also should've not been popped out
| @@ -1,5 +1,5 @@ | |||
| #pragma once | |||
| #include <cstdint> | |||
| #include <stdint.h> | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.