Build libc++abi with _LIBCXXABI_USE_FUTEX and emscripten futex API#26345
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Feb 26, 2026
Merged
Build libc++abi with _LIBCXXABI_USE_FUTEX and emscripten futex API#26345sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
juj
approved these changes
Feb 26, 2026
Collaborator
juj
left a comment
juj
left a comment
There was a problem hiding this comment.
This does not yet resolve the missing pthread_mutex_* and pthread_condvar_* dependencies, right?
juj
reviewed
Feb 26, 2026
| emscripten_futex_wait(addr, expect, INFINITY); | ||
| } | ||
| void PlatformFutexWake(int* addr) { | ||
| emscripten_futex_wake(addr, INT_MAX); |
Collaborator
There was a problem hiding this comment.
Did we have any tsan support yet?
Collaborator
Author
There was a problem hiding this comment.
No, we don't have any TSAN support.
Collaborator
Author
Exactly, yes |
dschuff
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the dependency that libc++abi has on the pthread API functions, allowing
better support for Wasm Workers.
Replaces: #26283
Fixes: #26277