[WasmFS] Skip mounting special files under NODERAWFS#26607
[WasmFS] Skip mounting special files under NODERAWFS#26607kleisauke wants to merge 3 commits intoemscripten-core:mainfrom
Conversation
This is an automatic change generated by tools/maint/rebaseline_tests.py. The following (2) test expectation files were updated by running the tests with `--rebaseline`: ``` codesize/test_codesize_cxx_wasmfs.json: 179737 => 179764 [+27 bytes / +0.02%] codesize/test_codesize_files_wasmfs.json: 63883 => 63908 [+25 bytes / +0.04%] Average change: +0.03% (+0.02% - +0.04%) ```
| virtual std::shared_ptr<Directory> createDirectory(mode_t mode) = 0; | ||
| virtual std::shared_ptr<Symlink> createSymlink(std::string target) = 0; | ||
|
|
||
| virtual bool shouldMountSpecialFiles() { return true; } |
There was a problem hiding this comment.
I was thinking maybe shouldPopulateRoot, but maybe your name is more explicit?
There was a problem hiding this comment.
This function name was mentioned in comment #24733 (comment). But I'd like shouldPopulateRoot as well.
| self.set_setting('WASMFS') | ||
| self.do_run_in_out_file_test('wasmfs/wasmfs_chown.c') | ||
|
|
||
| @wasmfs_all_backends |
There was a problem hiding this comment.
Why remove this?
Does wasmfs_getdents.c need to get re-written to handle the rawfs mabye?
There was a problem hiding this comment.
Should we just skip under NODERAWFS rather than removing wasmfs_all_backends completely?
There was a problem hiding this comment.
I re-added the @wasmfs_all_backends decorator and skipped this only under NODERAWFS with commit f3b85c9.
See for details:
emscripten/test/wasmfs/wasmfs_getdents.out
Lines 51 to 59 in 34f6bcf
|
Perhaps this setup logic belongs in the $ tree / -L 3 --dirsfirst
/ (NODERAWFS)
└── memory (MEMFS)
├── dev
│ ├── null -> SpecialFiles::getNull()
│ ├── random -> SpecialFiles::getRandom()
│ ├── stderr -> SpecialFiles::getStderr()
│ ├── stdin -> SpecialFiles::getStdin()
│ ├── stdout -> SpecialFiles::getStdout()
│ └── urandom -> SpecialFiles::getURandom()
└── tmpThis would avoid the need of the |
2 participants
Resolves: #24836.
Split out from #24733.