Implement precise pthread wakeups#26659
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
Conversation
sbc100
force-pushed
the
precise_wakeups
branch
3 times, most recently
from
61f016e to
20d6937
Compare
Member
|
"implemenat" => "implements" in description. |
tlively
reviewed
Apr 9, 2026
sbc100
force-pushed
the
precise_wakeups
branch
3 times, most recently
from
cb1c872 to
8dc3c30
Compare
tlively
reviewed
Apr 11, 2026
sbc100
force-pushed
the
precise_wakeups
branch
2 times, most recently
from
323fe09 to
0d4e436
Compare
sbc100
force-pushed
the
precise_wakeups
branch
2 times, most recently
from
e9a4dc9 to
fc5985b
Compare
This change implements the design in docs/design/01-precise-futex-wakeups.md Note: As part of this change the definition of emscripten_futex_wait was changes to explicitly allow spurious wakeups. Fixes: emscripten-core#26633
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements the design in docs/design/01-precise-futex-wakeups.md.
As part of this change emscripten_futex_wait API now explicitly allows spurious wakeups, much like the corresponding linux syscall. There were a couple of tests that were using
emscripten_futex_waitwithout a loop, so I added loops to them in an abundance of caution.Fixes: #26633