Cleanup test_asan_no_error test. NFC#26674
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
Cleanup test_asan_no_error test. NFC#26674sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
Collaborator
sbc100
commented
Apr 14, 2026
sbc100
commented
- Remove unnecessary command line flags
- Check for test output
- Return 0 from test (otherwise we don't actually detect asan failures).
- Restore final checks to before Check for expected error codes when running generated JS code #11578
- Remove unnecessary command line flags - Check for test output - Return 0 from test (otherwise we don't actually detect asan failures). - Restore final checks to before emscripten-core#11578
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.