Skip to content

Re-enable the temporarily disabled circleci tests. #26996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendandahl merged 4 commits into from
May 27, 2026
+44 −18
Merged

Re-enable the temporarily disabled circleci tests. #26996

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a407d6
Re-enable the temporarily disabled circleci tests.
brendandahl May 22, 2026
cd829db
Add Deno support to require_wasm64 helper
brendandahl May 22, 2026
a64ba97
Skip wasm64 on bun.
brendandahl May 22, 2026
1d8d1d7
Support exceptions for deno and bun.
brendandahl May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,6 +884,7 @@ jobs:
executor: linux-python
environment:
EMTEST_SKIP_NEW_CMAKE: "1"
EMTEST_SKIP_WASM64: "1"
Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does bun not support wasm64?

Copy link
Copy Markdown
Collaborator Author

@brendandahl brendandahl May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably does, but trying it out quickly it was failing. wasm64 tests use to be skipped on bun, so this really just restores the old behavior. I think we should enable in another PR.

Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 May 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How were they skipped before? In general I try not to ever implicitly skip any tests. But maybe this case was one that I fixed recently ? (i.e. did I remove the implicit skipping?)

Copy link
Copy Markdown
Collaborator Author

@brendandahl brendandahl May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same reason as the deno commit in this PR. This commit changed how it worked. We use always skip deno and bun before that.

Copy link
Copy Markdown
Collaborator

@sbc100 sbc100 May 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see yes, fair enough. They we being auto-skipped before.

steps:
- checkout
- pip-install
Expand Down Expand Up @@ -1389,9 +1390,9 @@ workflows:
- test-core0:
requires:
- build-linux
#- test-core2:
# requires:
# - build-linux
- test-core2:
requires:
- build-linux
- test-core3:
requires:
- build-linux
Expand All @@ -1410,9 +1411,9 @@ workflows:
- test-modularize-instance:
requires:
- build-linux
#- test-esm-integration:
# requires:
# - build-linux
- test-esm-integration:
requires:
- build-linux
- test-stress:
requires:
- build-linux
Expand All @@ -1434,14 +1435,14 @@ workflows:
- test-sockets-chrome:
requires:
- build-linux
#- test-bun
#- test-deno
#- test-jsc
- test-bun
- test-deno
- test-jsc
- test-spidermonkey
#- test-node-compat
#- test-windows
#- test-windows-browser-firefox
- test-node-compat
- test-windows
- test-windows-browser-firefox
- build-windows-launcher
#- test-mac-arm64:
# requires:
# - build-linux
- test-mac-arm64:
requires:
- build-linux
31 changes: 28 additions & 3 deletions test/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,7 +524,12 @@ def require_wasm64(self):
self.require_engine(v8)
return

self.fail('either d8 or node >= 24 required to run wasm64 tests. Use EMTEST_SKIP_WASM64 to skip')
deno = get_deno()
if deno:
self.require_engine(deno)
return

self.fail('either d8, node >= 24 or deno required to run wasm64 tests. Use EMTEST_SKIP_WASM64 to skip')

def try_require_node_version(self, major, minor=0, revision=0):
nodejs = get_nodejs()
Expand All @@ -549,13 +554,23 @@ def require_wasm_legacy_eh(self):
if self.try_require_node_version(17):
return

deno = get_deno()
if deno:
self.require_engine(deno)
return

bun = get_bun()
if bun:
self.require_engine(bun)
return

v8 = get_v8()
if v8:
self.cflags.append('-sENVIRONMENT=shell')
self.require_engine(v8)
return

self.fail('either d8 or node >= 17 required to run legacy wasm-eh tests. Use EMTEST_SKIP_WASM_LEGACY_EH to skip')
self.fail('either d8, deno, bun or node >= 17 required to run legacy wasm-eh tests. Use EMTEST_SKIP_WASM_LEGACY_EH to skip')

def require_wasm_eh(self):
if 'EMTEST_SKIP_WASM_EH' in os.environ:
Expand All @@ -570,14 +585,24 @@ def require_wasm_eh(self):
self.node_args.append('--experimental-wasm-exnref')
return

deno = get_deno()
if deno:
self.require_engine(deno)
return

bun = get_bun()
if bun:
self.require_engine(bun)
return

v8 = get_v8()
if v8:
self.cflags.append('-sENVIRONMENT=shell')
self.require_engine(v8)
self.v8_args.append('--experimental-wasm-exnref')
return

self.fail('either d8 or node v24 required to run wasm-eh tests. Use EMTEST_SKIP_WASM_EH to skip')
self.fail('either d8, deno, bun or node v24 required to run wasm-eh tests. Use EMTEST_SKIP_WASM_EH to skip')

def require_jspi(self):
if 'EMTEST_SKIP_JSPI' in os.environ:
Expand Down
Loading