Build arm64 version of pylauncher.exe#27360
Conversation
dschuff
left a comment
dschuff
left a comment
There was a problem hiding this comment.
do we have users that are asking for this? Are they just building their own LLVM and Binaryen?
| steps: | ||
| - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
| - name: Setup MSVC | ||
| uses: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756 # v1.13.0 |
There was a problem hiding this comment.
is it bad to use a devenv from some random person? Is there really not an official one?
There was a problem hiding this comment.
I seems like github actions doesn't have way to get cl.exe in the PATH by default.
There is another implementation at https://github.com/egor-tensin/vs-shell.
We could also try to take the approach we used on circleci and write out own bat file: https://github.com/emscripten-core/emscripten/blob/main/.circleci/setup_vs2022.bat
There was a problem hiding this comment.
This seems fine, especially keeping the version pinned by hash.
@juj was asking about it in #24858 (comment) |
| set OUT=pylauncher.exe | ||
| set MACHINE=X64 | ||
|
|
||
| if /i "%~1"=="arm64" ( |
There was a problem hiding this comment.
I will take your word for it that this is the best way to do this 😅
| steps: | ||
| - uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0 | ||
| - name: Setup MSVC | ||
| uses: ilammy/msvc-dev-cmd@0b201ec74fa43914dc39ae48a89fd1d8cb592756 # v1.13.0 |
There was a problem hiding this comment.
This seems fine, especially keeping the version pinned by hash.
2 participants
The executable comes it at just 6144 bytes.