Skip to content

Update mimalloc to 3.4.1#27380

Merged
sbc100 merged 6 commits into
emscripten-core:mainfrom
kleisauke:mimalloc-update-3.4.1
Jul 22, 2026
Merged

Update mimalloc to 3.4.1#27380
sbc100 merged 6 commits into
emscripten-core:mainfrom
kleisauke:mimalloc-update-3.4.1

Conversation

@kleisauke

Copy link
Copy Markdown
Collaborator

No description provided.

@kleisauke

Copy link
Copy Markdown
Collaborator Author

Created via:

  1. Replace system/lib/mimalloc/ with original mimalloc v3.3.1.
  2. Commit those changes.
  3. Upgrade to mimalloc v3.4.1.
  4. Revert the changes from step 2 (see commit 2250515).

@sbc100 sbc100 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume no extra patches were made?

@kleisauke

kleisauke commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator Author

I assume no extra patches were made?

Indeed, no extra patches were made (and some of them have been upstreamed, see e.g. commit microsoft/mimalloc@b642693, microsoft/mimalloc@c2b4c6c, microsoft/mimalloc@63eac7d and microsoft/mimalloc@58b36a3). The only change needed was to rebase the codesize expectations for other.test_malloc_size_mimalloc.

@sbc100
sbc100 requested a review from kripken July 20, 2026 17:26
@sbc100

sbc100 commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

lgtm but maybe lets check with @kripken too?

@sbc100

sbc100 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Looks like the ChangeLog entry needs rebasing

@sbc100
sbc100 merged commit 62af666 into emscripten-core:main Jul 22, 2026
40 checks passed
@kleisauke
kleisauke deleted the mimalloc-update-3.4.1 branch July 22, 2026 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants