Merged
Conversation
Leading `--` comments in positional arguments get parsed as CLI flags. Document the workaround of using the `--query` named flag instead.
There was a problem hiding this comment.
Code Review
This pull request adds a 'Gotchas' section to the documentation in lib/llm/index.js to address issues where multi-line SQL comments are misinterpreted as CLI flags. The review feedback correctly identifies that the sqlcmd query subcommand lacks a --query flag and suggests using the -- separator to properly handle positional arguments starting with dashes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--comments breaks when passed as a positional argument tosqlcmd query--querynamed flag as a workaroundDiscovered during NX-15422 when
sqlcmd query "$(cat file.sql)"failed because the leading SQL comments were parsed as CLI flags.Test plan
npm startand verify docs generate correctly