Skip to content

fix(docs): align navbar GitHub button height with Sign in button - #1000

Open
Jordy-Baby wants to merge 2 commits into
mainfrom
design/navbar-github-button
Open

fix(docs): align navbar GitHub button height with Sign in button#1000
Jordy-Baby wants to merge 2 commits into
mainfrom
design/navbar-github-button

Conversation

@Jordy-Baby

@Jordy-Baby Jordy-Baby commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Boxes the navbar GitHub button and pins it to the same height as the Sign in button so the two line up. Matches the boxed GitHub button on envio.dev.

  • GitHub button: bordered box, 38px, centred icon
  • Sign in: pinned to the same 38px height
  • Global navbar, so it applies across every docs page

Verified locally on desktop and mobile (both buttons render at exactly 38px, top/bottom aligned).

Screenshots

Before, bare GitHub icon sitting shorter than the Sign in button.

before buttons

After, bordered 38px box aligned with Sign in.

after buttons

Full navbar for context.

Before

before navbar

After

after navbar

Summary by CodeRabbit

  • Style
    • Refined the GitHub navigation icon with a bordered, rounded 38×38 layout and updated hover effects.
    • Improved desktop “Sign in” button alignment and sizing while preserving its existing visual appearance.

@vercel

vercel Bot commented Jul 14, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
envio-docs Ready Ready Preview Jul 30, 2026 7:34pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Updated navbar CSS for the GitHub icon link and sign-in button, including dimensions, alignment, borders, hover behavior, icon sizing, and transitions.

Changes

Navbar control styling

Layer / File(s) Summary
Navbar control layout and interaction styling
src/css/custom.css
The GitHub link uses a centered 38×38 bordered box with a 20×20 icon and revised hover transitions; the sign-in button uses centered inline-flex layout, a 38px height, and updated padding.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Suggested reviewers: nikbhintade

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is specific and accurately reflects the main UI change: aligning the GitHub navbar button with the Sign in button.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Jordy-Baby
Jordy-Baby requested a review from nikbhintade July 14, 2026 18:06
@Jordy-Baby
Jordy-Baby enabled auto-merge (squash) July 30, 2026 19:27
envio.dev renders both the GitHub button and Sign in at 38px. This branch
pinned them to 36px, so the docs navbar matched the treatment but not the
size. Bumps both to 38px.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant