Skip to content

ci: Migrate to github/RBE (+ cleanup/fix CI) #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
phlax merged 3 commits into from
Jun 18, 2025
Merged

ci: Migrate to github/RBE (+ cleanup/fix CI) #1251

phlax merged 3 commits into from
Jun 18, 2025

Conversation

@phlax
Copy link
Member

@phlax phlax commented Nov 1, 2024 •
edited by mum4k
Loading

Done here:

  • migrate CI from AZP to github actions
  • enable RBE when building Nighthawk
  • removed excessive test output, limiting output mostly to error messages
  • removed action_env when selecting to run stress tests and switched to a custom flag to prevent build cache from blowing up, change documented in test/config/README.md
  • running sanitizers in parallel with the test phase to speed up the execution
  • eliminated cases where benchmark tests combined py_test and py_binary into a single main
  • no longer faking home and overriding TEST_TMPDIR and user when running under Docker, a workaround likely needed because of the combined py_test and py_binary
  • selecting the right number of cores for multiprocessing, instead of a constant

phlax
phlax commented Nov 1, 2024
View reviewed changes
phlax
phlax commented Nov 1, 2024
View reviewed changes
phlax
phlax commented Nov 1, 2024
View reviewed changes
@phlax phlax force-pushed the rbe-hello branch 3 times, most recently from 25d1695 to 0a72932 Compare June 17, 2025 16:24
@phlax phlax changed the title rbe: Testing ci: Migrate to github/RBE Jun 17, 2025
phlax
phlax commented Jun 17, 2025
View reviewed changes
@phlax phlax force-pushed the rbe-hello branch 7 times, most recently from 3d81c72 to a3024b7 Compare June 18, 2025 12:57
@phlax phlax changed the title ci: Migrate to github/RBE ci: Migrate to github/RBE (+ cleanup/fix CI) Jun 18, 2025
phlax
phlax commented Jun 18, 2025
View reviewed changes
phlax
phlax commented Jun 18, 2025
View reviewed changes
@phlax phlax force-pushed the rbe-hello branch 3 times, most recently from 205471c to 46066ff Compare June 18, 2025 13:42
phlax
phlax commented Jun 18, 2025
View reviewed changes
@phlax phlax force-pushed the rbe-hello branch 4 times, most recently from 9149515 to 55d8b15 Compare June 18, 2025 14:28
phlax
phlax commented Jun 18, 2025
View reviewed changes
@phlax
ci: Migrate to github/RBE
1784a65 
Signed-off-by: Ryan Northey <[email protected]>
mum4k
mum4k reviewed Jun 18, 2025
View reviewed changes
@mum4k mum4k requested a review from eric846 June 18, 2025 14:51
phlax
phlax commented Jun 18, 2025
View reviewed changes
@phlax
cleanups
a1f1ab4 
Signed-off-by: Ryan Northey <[email protected]>
@phlax
cleanup
2d02a5b 
Signed-off-by: Ryan Northey <[email protected]>
eric846
eric846 approved these changes Jun 18, 2025
View reviewed changes
@phlax phlax merged commit cfb2320 into envoyproxy:main Jun 18, 2025
9 checks passed
@eric846 eric846 mentioned this pull request Jun 18, 2025
Merged
asingh-g pushed a commit to asingh-g/nighthawk that referenced this pull request Jul 1, 2025
@phlax @asingh-g
ci: Migrate to github/RBE (+ cleanup/fix CI) (envoyproxy#1251)
6c96fcf 
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: asingh-g <[email protected]>
asingh-g pushed a commit to asingh-g/nighthawk that referenced this pull request Jul 2, 2025
@phlax @asingh-g
ci: Migrate to github/RBE (+ cleanup/fix CI) (envoyproxy#1251)
f55df68 
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: asingh-g <[email protected]>
asingh-g pushed a commit to asingh-g/nighthawk that referenced this pull request Sep 15, 2025
@phlax @asingh-g
ci: Migrate to github/RBE (+ cleanup/fix CI) (envoyproxy#1251)
947bcaf 
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: asingh-g <[email protected]>
asingh-g pushed a commit to asingh-g/nighthawk that referenced this pull request Sep 15, 2025
@phlax @asingh-g
ci: Migrate to github/RBE (+ cleanup/fix CI) (envoyproxy#1251)
a4d5866 
Signed-off-by: Ryan Northey <[email protected]>
Signed-off-by: asingh-g <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eric846 eric846 eric846 approved these changes

@mum4k mum4k mum4k approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phlax @mum4k @eric846