Closed
Conversation
78dfc02 to
65ccc82
Compare
* use remove() to avoid cloning in initializes_read_schema * simplify initial read schema discovery codepaths * simplify setting on inferred schemas * Initialize shapes with default complexity limit annotation * Raise complexity limit to 10,000 when sourced schemas are applied in apply_sourced_schemas
65ccc82 to
1545364
Compare
Contributor
Author
|
@jgraettinger I put this together a while ago and finally got around to actually testing it, and in the intervening time some other changes happened to Edit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This addresses the remaining PR feedback from #2263
x-complexity-limiton inferred schemasTested this locally with a


hello-worldandpostgresconnector, confirming that their behavior is expected: hello-world hasx-complexity-limit: 1000and postgres hasx-complexity-limit: 10000This change is