feat(api): add patch endpoint to update issuer label#5472
Merged
Conversation
3 tasks
akrem-chabchoub
changed the title
martinconic
approved these changes
Jun 9, 2026
gacevicljubisa
left a comment
gacevicljubisa
left a comment
Member
There was a problem hiding this comment.
Looks ok.
Maybe you can consider adding TestUpdateIssuerLabel on the postage service level which will cover ErrNotFound, and the in-memory update
|
|
||
| for _, st := range ps.issuers { | ||
| if bytes.Equal(batchID, st.data.BatchID) { | ||
| st.data.Label = label |
Member
There was a problem hiding this comment.
There is data race on data.Label when we have concurent GET + PATCH on the same batch.
gacevicljubisa
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Adds a
PATCH /stamps/{batch_id}endpoint that lets a node operator update the label of an existing postage batch issuer. The label is local metadata only, it has no on-chain effect and requires no transaction. The change is persisted to the stamp store so it survives node restarts.Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure