Skip to content

Conversation

@xBlaz3kx
Copy link
Contributor

@xBlaz3kx xBlaz3kx commented Dec 7, 2025

Added test coverage reporting on PR. It will create a comment on the PR with coverage percentage.

I think its important, even though this is a community project, to maintain a high level of test coverage.

@andig andig added enhancement New feature or request infrastructure Basic functionality labels Dec 7, 2025
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • The code_coverage job’s explicit actions/download-artifact step is redundant with fgrosse/go-coverage-report’s built‑in artifact download (via coverage-artifact-name); you can drop the manual download step and let the action handle retrieving coverage.out.
  • Changing the default test target to always write coverage.out may be intrusive for local development (e.g., leaving coverage files around or impacting tooling); consider adding a separate test-cover target for CI and keeping test as a plain go test invocation.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `code_coverage` job’s explicit `actions/download-artifact` step is redundant with `fgrosse/go-coverage-report`’s built‑in artifact download (via `coverage-artifact-name`); you can drop the manual download step and let the action handle retrieving `coverage.out`.
- Changing the default `test` target to always write `coverage.out` may be intrusive for local development (e.g., leaving coverage files around or impacting tooling); consider adding a separate `test-cover` target for CI and keeping `test` as a plain `go test` invocation.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request infrastructure Basic functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants