fix(config): ignore invalid custom split config#2242
Merged
Seiger merged 1 commit intoevolution-cms:3.5.xfrom Mar 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #2196 reports a white-screen / HTTP 500 after creating
core/custom/config/cms/settings/ControllerNamespace.php. On current3.5.x, the failure path comes from bootstrap config loading: an invalid custom split config file is required directly and kills the whole runtime with aParseError.Why
This PR makes the custom config layer resilient without hiding real platform breakage. Custom user config mistakes should not take down the whole application, but invalid core config should still stay fatal.
What Changed
core/src/AbstractLaravel.phpwith a narrowParseErrorguardcore/custom/config/**are now skipped and logged instead of crashing bootstrapWhere
core/src/AbstractLaravel.phpcore/tests/Unit/AbstractLaravelLoadConfigurationTest.phpVerification
./vendor/bin/pest tests/Unit/AbstractLaravelLoadConfigurationTest.php./vendor/bin/pest tests/Feature/ModifiersTest.phpphp -l core/src/AbstractLaravel.phpphp -l core/tests/Unit/AbstractLaravelLoadConfigurationTest.phpcore/custom/config/cms/settings/ControllerNamespace.phpnow logs and falls back instead of fatalingRemaining Gaps