Skip to content

ref(constants): use evo manager path helpers#2244

Open
middleDuckAi wants to merge 1 commit intoevolution-cms:3.5.xfrom
middleDuckAi:middleDuck/evo-2238-manager-path-constants
Open

ref(constants): use evo manager path helpers#2244
middleDuckAi wants to merge 1 commit intoevolution-cms:3.5.xfrom
middleDuckAi:middleDuck/evo-2238-manager-path-constants

Conversation

@middleDuckAi
Copy link
Collaborator

Problem

Issue #2238 is broader than one safe PR. After the bootstrap/runtime slice, manager path and URL helpers were still using legacy MODX_* constants across core helpers and manager frame views.

Why this approach

This keeps the migration incremental:

  • switch canonical core manager path/url helpers to EVO_*
  • update manager frame/views to publish and consume EVO_* first
  • keep compatibility aliases where frontend runtime still expects MODX_*

What changed

  • updated Path, Settings, ManagerTheme, ManagerActions, Frame, and Users\\LogInOut to use EVO_* manager/site/base constants
  • updated manager frame and tree views to emit EVO_* URLs and keep MODX_* JS aliases for compatibility
  • updated document view/preview manager surfaces to use EVO_SITE_URL
  • added regression coverage for manager path/url helper usage

Files / surfaces

  • core manager path/url helpers
  • manager frame runtime constants
  • manager tree and preview view URLs
  • targeted unit coverage for manager constant usage

Verification

  • ./vendor/bin/phpunit tests/Unit/ManagerPathConstantUsageTest.php
  • ./vendor/bin/pest tests/Feature/ModifiersTest.php
  • php -l on touched files
  • local runtime smoke check on the task branch

Risks

This is still only a bounded slice of #2238. Legacy aliases stay in place where needed so existing manager JS keeps working while the codebase shifts to canonical EVO_* constants.

Links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants