ref(constants): use evo manager path helpers#2244
Open
middleDuckAi wants to merge 1 commit intoevolution-cms:3.5.xfrom
Open
ref(constants): use evo manager path helpers#2244middleDuckAi wants to merge 1 commit intoevolution-cms:3.5.xfrom
middleDuckAi wants to merge 1 commit intoevolution-cms:3.5.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue #2238 is broader than one safe PR. After the bootstrap/runtime slice, manager path and URL helpers were still using legacy
MODX_*constants across core helpers and manager frame views.Why this approach
This keeps the migration incremental:
EVO_*EVO_*firstMODX_*What changed
Path,Settings,ManagerTheme,ManagerActions,Frame, andUsers\\LogInOutto useEVO_*manager/site/base constantsEVO_*URLs and keepMODX_*JS aliases for compatibilityEVO_SITE_URLFiles / surfaces
Verification
./vendor/bin/phpunit tests/Unit/ManagerPathConstantUsageTest.php./vendor/bin/pest tests/Feature/ModifiersTest.phpphp -lon touched filesRisks
This is still only a bounded slice of #2238. Legacy aliases stay in place where needed so existing manager JS keeps working while the codebase shifts to canonical
EVO_*constants.Links